From: Pedro Alves <pedro@palves.net>
Date: Mon, 17 Oct 2022 16:48:35 +0000 (+0100)
Subject: gdbarch-components.py: Remove spurious space from "frame_info_ptr " params
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=39e9d8670cea9d3d2959387b6d51050b0716eb19;p=binutils-gdb.git

gdbarch-components.py: Remove spurious space from "frame_info_ptr " params

If you run gdbarch.py today, you'll get local modifications compared
to what's in the tree, like:

 --- c/gdb/gdbarch-gen.h
 +++ w/gdb/gdbarch-gen.h
 @@ -315,8 +315,8 @@ extern void set_gdbarch_register_type (struct gdbarch *gdbarch, gdbarch_register
     should match the address at which the breakpoint was set in the dummy
     frame. */

 -typedef struct frame_id (gdbarch_dummy_id_ftype) (struct gdbarch *gdbarch, frame_info_ptr this_frame);
 -extern struct frame_id gdbarch_dummy_id (struct gdbarch *gdbarch, frame_info_ptr this_frame);
 +typedef struct frame_id (gdbarch_dummy_id_ftype) (struct gdbarch *gdbarch, frame_info_ptr  this_frame);
 +extern struct frame_id gdbarch_dummy_id (struct gdbarch *gdbarch, frame_info_ptr  this_frame);
  extern void set_gdbarch_dummy_id (struct gdbarch *gdbarch, gdbarch_dummy_id_ftype *dummy_id);

etc.

The extra space comes from the "frame_info_ptr " param that appears in
a number of gdbarch methods in gdbarch-components.py.  With the extra
space removed, running ./gdbarch.py generates the exact code that's in
the tree already.

Change-Id: If7d20b8c6b2fd9ff466142a01bd2611c9ef9f53e
---

diff --git a/gdb/gdbarch-components.py b/gdb/gdbarch-components.py
index ba16f4a6a1a..46e7565f293 100644
--- a/gdb/gdbarch-components.py
+++ b/gdb/gdbarch-components.py
@@ -613,7 +613,7 @@ frame.
 """,
     type="struct frame_id",
     name="dummy_id",
-    params=[("frame_info_ptr ", "this_frame")],
+    params=[("frame_info_ptr", "this_frame")],
     predefault="default_dummy_id",
     invalid=False,
 )
@@ -676,7 +676,7 @@ Return true if the code of FRAME is writable.
 """,
     type="int",
     name="code_of_frame_writable",
-    params=[("frame_info_ptr ", "frame")],
+    params=[("frame_info_ptr", "frame")],
     predefault="default_code_of_frame_writable",
     invalid=False,
 )
@@ -686,7 +686,7 @@ Method(
     name="print_registers_info",
     params=[
         ("struct ui_file *", "file"),
-        ("frame_info_ptr ", "frame"),
+        ("frame_info_ptr", "frame"),
         ("int", "regnum"),
         ("int", "all"),
     ],
@@ -699,7 +699,7 @@ Method(
     name="print_float_info",
     params=[
         ("struct ui_file *", "file"),
-        ("frame_info_ptr ", "frame"),
+        ("frame_info_ptr", "frame"),
         ("const char *", "args"),
     ],
     predefault="default_print_float_info",
@@ -711,7 +711,7 @@ Method(
     name="print_vector_info",
     params=[
         ("struct ui_file *", "file"),
-        ("frame_info_ptr ", "frame"),
+        ("frame_info_ptr", "frame"),
         ("const char *", "args"),
     ],
     predicate=True,
@@ -755,7 +755,7 @@ FRAME corresponds to the longjmp frame.
 """,
     type="int",
     name="get_longjmp_target",
-    params=[("frame_info_ptr ", "frame"), ("CORE_ADDR *", "pc")],
+    params=[("frame_info_ptr", "frame"), ("CORE_ADDR *", "pc")],
     predicate=True,
     invalid=True,
 )
@@ -778,7 +778,7 @@ Function(
     type="int",
     name="register_to_value",
     params=[
-        ("frame_info_ptr ", "frame"),
+        ("frame_info_ptr", "frame"),
         ("int", "regnum"),
         ("struct type *", "type"),
         ("gdb_byte *", "buf"),
@@ -792,7 +792,7 @@ Function(
     type="void",
     name="value_to_register",
     params=[
-        ("frame_info_ptr ", "frame"),
+        ("frame_info_ptr", "frame"),
         ("int", "regnum"),
         ("struct type *", "type"),
         ("const gdb_byte *", "buf"),
@@ -1065,7 +1065,7 @@ Value(
 Method(
     type="CORE_ADDR",
     name="unwind_pc",
-    params=[("frame_info_ptr ", "next_frame")],
+    params=[("frame_info_ptr", "next_frame")],
     predefault="default_unwind_pc",
     invalid=False,
 )
@@ -1073,7 +1073,7 @@ Method(
 Method(
     type="CORE_ADDR",
     name="unwind_sp",
-    params=[("frame_info_ptr ", "next_frame")],
+    params=[("frame_info_ptr", "next_frame")],
     predefault="default_unwind_sp",
     invalid=False,
 )
@@ -1085,7 +1085,7 @@ frame-base.  Enable frame-base before frame-unwind.
 """,
     type="int",
     name="frame_num_args",
-    params=[("frame_info_ptr ", "frame")],
+    params=[("frame_info_ptr", "frame")],
     predicate=True,
     invalid=True,
 )
@@ -1260,7 +1260,7 @@ further single-step is needed before the instruction finishes.
 """,
     type="int",
     name="single_step_through_delay",
-    params=[("frame_info_ptr ", "frame")],
+    params=[("frame_info_ptr", "frame")],
     predicate=True,
     invalid=True,
 )
@@ -1280,7 +1280,7 @@ disassembler.  Perhaps objdump can handle it?
 Function(
     type="CORE_ADDR",
     name="skip_trampoline_code",
-    params=[("frame_info_ptr ", "frame"), ("CORE_ADDR", "pc")],
+    params=[("frame_info_ptr", "frame"), ("CORE_ADDR", "pc")],
     predefault="generic_skip_trampoline_code",
     invalid=False,
 )
@@ -1503,7 +1503,7 @@ Fetch the pointer to the ith function argument.
     type="CORE_ADDR",
     name="fetch_pointer_argument",
     params=[
-        ("frame_info_ptr ", "frame"),
+        ("frame_info_ptr", "frame"),
         ("int", "argi"),
         ("struct type *", "type"),
     ],
@@ -2664,7 +2664,7 @@ Return a string containing any flags for the given PC in the given FRAME.
 """,
     type="std::string",
     name="get_pc_address_flags",
-    params=[("frame_info_ptr ", "frame"), ("CORE_ADDR", "pc")],
+    params=[("frame_info_ptr", "frame"), ("CORE_ADDR", "pc")],
     predefault="default_get_pc_address_flags",
     invalid=False,
 )