From: Peter Hutterer <peter@cs.unisa.edu.au>
Date: Thu, 21 Aug 2008 09:22:40 +0000 (+0200)
Subject: Report damage before modifying the area, not after.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=3a94b25538c647df965a93cd7734b841257ef203;p=mesa.git

Report damage before modifying the area, not after.

If we copy the area before reporting the damage in this area, the server may
restore buffered data over the new data, leading to artefacts on the screen.
Reproducable with two cursors (second of which is SW rendered) and moving
windows around in compiz.

Fixes http://bugs.freedesktop.org/show_bug.cgi?id=16384 .
---

diff --git a/src/mesa/drivers/dri/common/dri_util.c b/src/mesa/drivers/dri/common/dri_util.c
index 9655741bbba..93b9f458e41 100644
--- a/src/mesa/drivers/dri/common/dri_util.c
+++ b/src/mesa/drivers/dri/common/dri_util.c
@@ -512,13 +512,13 @@ static void driCopySubBuffer(__DRIdrawable *dPriv,
 {
     drm_clip_rect_t rect;
 
-    dPriv->driScreenPriv->DriverAPI.CopySubBuffer(dPriv, x, y, w, h);
-
     rect.x1 = x;
     rect.y1 = dPriv->h - y - h;
     rect.x2 = x + w;
     rect.y2 = rect.y1 + h;
     driReportDamage(dPriv, &rect, 1);
+
+    dPriv->driScreenPriv->DriverAPI.CopySubBuffer(dPriv, x, y, w, h);
 }
 
 const __DRIcopySubBufferExtension driCopySubBufferExtension = {