From: Iain Sandoe Date: Thu, 28 Nov 2019 19:41:55 +0000 (+0000) Subject: [Darwin, X86, testsuite] Update tests for common section use. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=3a95e31b34da8d7b01744f1f5958541b0671df5f;p=gcc.git [Darwin, X86, testsuite] Update tests for common section use. The switch to default of no-common means that we no longer indirect the accesses to 'xxx' in this test. Adjust the scan- assembler tests to reflect this. gcc/testsuite/ChangeLog: 2019-11-28 Iain Sandoe * gcc.target/i386/pr32219-2.c: Adjust scan-assembler entries for revised common default. From-SVN: r278818 --- diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog index 65e7ffc3c23..ac1a4be9888 100644 --- a/gcc/testsuite/ChangeLog +++ b/gcc/testsuite/ChangeLog @@ -1,3 +1,8 @@ +2019-11-28 Iain Sandoe + + * gcc.target/i386/pr32219-2.c: Adjust scan-assembler entries + for revised common default. + 2019-11-28 Jerry DeLisle PR fortran/90374 diff --git a/gcc/testsuite/gcc.target/i386/pr32219-2.c b/gcc/testsuite/gcc.target/i386/pr32219-2.c index b6212f7dd4c..a9c18ba1995 100644 --- a/gcc/testsuite/gcc.target/i386/pr32219-2.c +++ b/gcc/testsuite/gcc.target/i386/pr32219-2.c @@ -12,13 +12,12 @@ foo () } /* { dg-final { scan-assembler-not "movl\[ \t\]xxx\\(%rip\\), %" { target { ! ia32 } } } } */ -/* For Darwin m64 we are always PIC, but common symbols are indirected, which happens to - match the general "ELF" case. */ -/* { dg-final { scan-assembler "xxx@GOTPCREL" { target { ! ia32 } } } } */ +/* For Darwin m64 PIC we make a direct access to this symbol. */ +/* { dg-final { scan-assembler "xxx@GOTPCREL" { target { { ! ia32 } && { ! *-*-darwin* } } } } } */ /* { dg-final { scan-assembler-not "movl\[ \t\]xxx@GOTOFF\\(%\[^,\]*\\), %" { target { ia32 && { ! *-*-darwin* } } } } } */ /* { dg-final { scan-assembler "movl\[ \t\]xxx@GOT\\(%\[^,\]*\\), %" { target { ia32 && { ! *-*-darwin* } } } } } */ -/* Darwin m32 defaults to PIC but common symbols need to be indirected. */ -/* { dg-final { scan-assembler {movl[ \t][Ll]_xxx\$non_lazy_ptr-L1\$pb\(%eax\),[ \t]%eax} { target { ia32 && *-*-darwin* } } } } */ +/* Darwin m32 PIC requires the picbase adjustment. */ +/* { dg-final { scan-assembler {movl[ \t]_xxx-L1\$pb\(%eax\),[ \t]%eax} { target { ia32 && *-*-darwin* } } } } */