From: Matt Turner Date: Mon, 13 Apr 2015 18:29:14 +0000 (-0700) Subject: i965/fs: Correct mistake in determining whether a MUL is negated. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=3ca17e75e4fe129511a4dcad47e139485beef880;p=mesa.git i965/fs: Correct mistake in determining whether a MUL is negated. a * b is equivalent to -a * -b, and the previous code was failing at that. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=89961 Reviewed-by: Anuj Phogat Reviewed-by: Ian Romanick --- diff --git a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp index f2c40986683..c1d06161cbf 100644 --- a/src/mesa/drivers/dri/i965/brw_fs_cse.cpp +++ b/src/mesa/drivers/dri/i965/brw_fs_cse.cpp @@ -145,7 +145,7 @@ operands_match(const fs_inst *a, const fs_inst *b, bool *negate) xs[1].fixed_hw_reg.dw1.f = xs1_imm; ys[1].fixed_hw_reg.dw1.f = ys1_imm; - *negate = (xs0_negate + xs1_negate) != (ys0_negate + ys1_negate); + *negate = (xs0_negate != xs1_negate) != (ys0_negate != ys1_negate); return ret; } else if (!a->is_commutative()) { bool match = true;