From: Rob Clark <robclark@freedesktop.org>
Date: Thu, 26 May 2016 14:22:33 +0000 (-0400)
Subject: tgsi: fix out of bounds access
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=3d66ba971e984a1c58eda6a938a37f58ba6f8134;p=mesa.git

tgsi: fix out of bounds access

Not sure why coverity calls this an out-of-bounds read vs out-of-bounds
write.

CID 1358920 (#1 of 1): Out-of-bounds read (OVERRUN)9. overrun-local:
Overrunning array r of 3 16-byte elements at element index 3 (byte
offset 48) using index chan (which evaluates to 3).

Signed-off-by: Rob Clark <robclark@freedesktop.org>
Reviewed-by: Brian Paul <brianp@vmware.com>
---

diff --git a/src/gallium/auxiliary/tgsi/tgsi_exec.c b/src/gallium/auxiliary/tgsi/tgsi_exec.c
index baf4a897c50..289fe043b7d 100644
--- a/src/gallium/auxiliary/tgsi/tgsi_exec.c
+++ b/src/gallium/auxiliary/tgsi/tgsi_exec.c
@@ -3851,7 +3851,7 @@ static void
 exec_load_mem(struct tgsi_exec_machine *mach,
               const struct tgsi_full_instruction *inst)
 {
-   union tgsi_exec_channel r[3];
+   union tgsi_exec_channel r[4];
    uint chan;
    char *ptr = mach->LocalMem;
    uint32_t offset;