From: Nick Alcock <nick.alcock@oracle.com>
Date: Sat, 13 Jul 2019 19:44:38 +0000 (+0100)
Subject: libctf: fix double-free on ctf_compress_write error path
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=3dde2c915e2c68fdda36febac618595561ed87f8;p=binutils-gdb.git

libctf: fix double-free on ctf_compress_write error path

We were freeing the compressed data buffer twice if compression failed.

v4: Fix commit message.
v5: fix tabdamage.

libctf/
	* ctf-create.c (ctf_compress_write): Fix double-free.
---

diff --git a/libctf/ChangeLog b/libctf/ChangeLog
index 04939431173..9e72d84ddc6 100644
--- a/libctf/ChangeLog
+++ b/libctf/ChangeLog
@@ -1,3 +1,7 @@
+2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
+
+	* ctf-create.c (ctf_compress_write): Fix double-free.
+
 2019-07-13  Nick Alcock  <nick.alcock@oracle.com>
 
 	* ctf-archive.c (ctf_arc_write): Split off, and reimplement in terms
diff --git a/libctf/ctf-create.c b/libctf/ctf-create.c
index 09cd8d57a52..d75de916eae 100644
--- a/libctf/ctf-create.c
+++ b/libctf/ctf-create.c
@@ -1997,7 +1997,6 @@ ctf_compress_write (ctf_file_t *fp, int fd)
     {
       ctf_dprintf ("zlib deflate err: %s\n", zError (rc));
       err = ctf_set_errno (fp, ECTF_COMPRESS);
-      ctf_free (buf);
       goto ret;
     }