From: Steve Reinhardt <stever@eecs.umich.edu>
Date: Tue, 3 Feb 2004 15:19:05 +0000 (-0800)
Subject: Fix bug: forgot branchTarget() method on indirect branches.
X-Git-Tag: m5_1.0_beta2~161^2~2
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=3e5070a3f121d84846de16718575567725129db9;p=gem5.git

Fix bug: forgot branchTarget() method on indirect branches.

arch/alpha/isa_desc:
    Add missing branchTarget() method for indirect branches.
cpu/static_inst.hh:
    Add comment clarifying when branchTarget() can be used
    on indirect branches.

--HG--
extra : convert_revision : 0dcfb36a9792a338cefceb3d1501825abace7ac5
---

diff --git a/arch/alpha/isa_desc b/arch/alpha/isa_desc
index 3533da09f..51bce65c2 100644
--- a/arch/alpha/isa_desc
+++ b/arch/alpha/isa_desc
@@ -1287,6 +1287,13 @@ declare {{
 	{
 	}
 
+	Addr branchTarget(ExecContext *xc)
+	{
+	    Addr NPC = xc->readPC() + 4;
+	    uint64_t Rb = xc->readIntReg(_srcRegIdx[0]);
+	    return (Rb & ~3) | (NPC & 1);
+	}
+
 	std::string generateDisassembly(Addr pc, const SymbolTable *symtab)
 	{
 	    std::stringstream ss;
diff --git a/cpu/static_inst.hh b/cpu/static_inst.hh
index 644c7dfc4..f3fd6fa24 100644
--- a/cpu/static_inst.hh
+++ b/cpu/static_inst.hh
@@ -312,10 +312,11 @@ class StaticInst : public StaticInstBase
     }
 
     /**
-     * Return the target address for an indirect branch (jump).
-     * The register value is read from the supplied execution context.
-     * Invalid if not an indirect branch (i.e. isIndirectCtrl()
-     * should be true).
+     * Return the target address for an indirect branch (jump).  The
+     * register value is read from the supplied execution context, so
+     * the result is valid only if the execution context is about to
+     * execute the branch in question.  Invalid if not an indirect
+     * branch (i.e. isIndirectCtrl() should be true).
      */
     virtual Addr branchTarget(ExecContext *xc)
     {