From: Mike Frysinger <vapier@gentoo.org>
Date: Thu, 11 Nov 2021 05:14:46 +0000 (-0500)
Subject: sim: io: tweak compiler workaround with error output
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=40f64666780b1c6511c49aca6d6016f11b58e785;p=binutils-gdb.git

sim: io: tweak compiler workaround with error output

Outputting an extra space broke a cris test.  Change the workaround
to use %s with an empty string to avoid the compiler warning but not
output an extra space.
---

diff --git a/sim/common/sim-io.c b/sim/common/sim-io.c
index 7bb504c7429..9fdc79e0301 100644
--- a/sim/common/sim-io.c
+++ b/sim/common/sim-io.c
@@ -308,9 +308,9 @@ sim_io_error (SIM_DESC sd,
     va_start (ap, fmt);
     STATE_CALLBACK (sd)->evprintf_filtered (STATE_CALLBACK (sd), fmt, ap);
     va_end (ap);
-    /* Printing a space here avoids empty printf compiler warnings.  Not ideal,
-       but we want error's side-effect where it halts processing.  */
-    STATE_CALLBACK (sd)->error (STATE_CALLBACK (sd), " ");
+    /* The %s avoids empty printf compiler warnings.  Not ideal, but we want
+       error's side-effect where it halts processing.  */
+    STATE_CALLBACK (sd)->error (STATE_CALLBACK (sd), "%s", "");
   }
 }