From: whitequark <whitequark@whitequark.org>
Date: Tue, 4 Jun 2019 10:23:27 +0000 (+0000)
Subject: build.res: use ConstraintError iff a constraint invariant is violated.
X-Git-Tag: locally_working~193
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=43102541032f0bb51775bc1756fd125b984d6de8;p=nmigen.git

build.res: use ConstraintError iff a constraint invariant is violated.

In particular don't use it for type errors.
---

diff --git a/nmigen/build/__init__.py b/nmigen/build/__init__.py
index 21ed40b..d13f3cd 100644
--- a/nmigen/build/__init__.py
+++ b/nmigen/build/__init__.py
@@ -1,2 +1,3 @@
 from .dsl import Pins, DiffPairs, Subsignal, Resource, Connector
+from .res import ConstraintError
 from .plat import Platform, TemplatedPlatform
diff --git a/nmigen/build/res.py b/nmigen/build/res.py
index bc388be..d1e4a4e 100644
--- a/nmigen/build/res.py
+++ b/nmigen/build/res.py
@@ -56,9 +56,9 @@ class ConstraintManager:
     def add_clock(self, name, number, frequency):
         resource = self.lookup(name, number)
         if isinstance(resource.io[0], Subsignal):
-            raise ConstraintError("Cannot constrain frequency of resource {}#{} because it has "
-                                  "subsignals"
-                                  .format(resource.name, resource.number, frequency))
+            raise TypeError("Cannot constrain frequency of resource {}#{} because it has "
+                            "subsignals"
+                            .format(resource.name, resource.number, frequency))
         if (resource.name, resource.number) in self.clocks:
             other = self.clocks[resource.name, resource.number]
             raise ConstraintError("Resource {}#{} is already constrained to a frequency of "
@@ -68,8 +68,8 @@ class ConstraintManager:
 
     def lookup(self, name, number=0):
         if (name, number) not in self.resources:
-            raise NameError("Resource {}#{} does not exist"
-                            .format(name, number))
+            raise ConstraintError("Resource {}#{} does not exist"
+                                  .format(name, number))
         return self.resources[name, number]
 
     def request(self, name, number=0, *, dir=None, xdr=None):
diff --git a/nmigen/test/test_build_res.py b/nmigen/test/test_build_res.py
index ace1c11..97fa337 100644
--- a/nmigen/test/test_build_res.py
+++ b/nmigen/test/test_build_res.py
@@ -192,12 +192,12 @@ class ConstraintManagerTestCase(FHDLTestCase):
             self.cm.add_connectors([Connector("pmod", 0, "1 2")])
 
     def test_wrong_lookup(self):
-        with self.assertRaises(NameError,
+        with self.assertRaises(ConstraintError,
                 msg="Resource user_led#1 does not exist"):
             r = self.cm.lookup("user_led", 1)
 
     def test_wrong_frequency_subsignals(self):
-        with self.assertRaises(ConstraintError,
+        with self.assertRaises(TypeError,
                 msg="Cannot constrain frequency of resource i2c#0 because "
                     "it has subsignals"):
             self.cm.add_clock("i2c", 0, 10e6)