From: Ilia Mirkin Date: Fri, 12 Feb 2016 17:17:18 +0000 (-0500) Subject: mesa: need to check resource and set length even if bufSize is 0 X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4360ba0cafa53506297235637e13acc5f0879531;p=mesa.git mesa: need to check resource and set length even if bufSize is 0 This fixes a number of dEQP tests, such as: dEQP-GLES31.functional.program_interface_query.buffer_limited_query.resource_query It was expecting the length to be set even in the bufSize == 0 case. Also _mesa_get_program_resourceiv does some error checking on the resource which should probably happen even in the bufSize == 0 case as well although there's no dEQP test for that. Signed-off-by: Ilia Mirkin Reviewed-by: Tapani Pälli --- diff --git a/src/mesa/main/program_resource.c b/src/mesa/main/program_resource.c index 50659b0cd21..0d9f8aecf08 100644 --- a/src/mesa/main/program_resource.c +++ b/src/mesa/main/program_resource.c @@ -357,10 +357,6 @@ _mesa_GetProgramResourceiv(GLuint program, GLenum programInterface, return; } - /* No need to write any properties, user requested none. */ - if (bufSize == 0) - return; - _mesa_get_program_resourceiv(shProg, programInterface, index, propCount, props, bufSize, length, params); }