From: Doug Evans <dje@google.com>
Date: Sun, 16 Aug 2009 17:32:35 +0000 (+0000)
Subject: 	* opncls.c (bfd_close): Until BFD_IN_MEMORY has an iovec,
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=440ae135a822be30029115ff739e1d0e16a07858;p=binutils-gdb.git

	* opncls.c (bfd_close): Until BFD_IN_MEMORY has an iovec,
	at least don't leak memory.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index ecca9ca072d..f9c4c6de077 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2009-08-16  Doug Evans  <dje@google.com>
+
+	* opncls.c (bfd_close): Until BFD_IN_MEMORY has an iovec,
+	at least don't leak memory.
+
 2009-08-13  DJ Delorie  <dj@redhat.com>
 
 	* elf32-m32c.c (m32c_elf_relax_delete_bytes): Adjust symbol sizes
diff --git a/bfd/opncls.c b/bfd/opncls.c
index 6a4f319d315..799203065ce 100644
--- a/bfd/opncls.c
+++ b/bfd/opncls.c
@@ -703,12 +703,18 @@ bfd_close (bfd *abfd)
   if (! BFD_SEND (abfd, _close_and_cleanup, (abfd)))
     return FALSE;
 
-  /* FIXME: cagney/2004-02-15: Need to implement a BFD_IN_MEMORY io
-     vector.  */
-  if (!(abfd->flags & BFD_IN_MEMORY))
-    ret = abfd->iovec->bclose (abfd);
+  if ((abfd->flags & BFD_IN_MEMORY) != 0)
+    {
+      /* FIXME: cagney/2004-02-15: Need to implement a BFD_IN_MEMORY io
+	 vector.
+	 Until that's done, at least don't leak memory.  */
+      struct bfd_in_memory *bim = abfd->iostream;
+      free (bim->buffer);
+      free (bim);
+      ret = TRUE;
+    }
   else
-    ret = TRUE;
+    ret = abfd->iovec->bclose (abfd);
 
   if (ret)
     _maybe_make_executable (abfd);