From: Andreas Sandberg <andreas.sandberg@arm.com>
Date: Fri, 4 Sep 2020 16:17:28 +0000 (+0100)
Subject: python: Remove unused debug APIs
X-Git-Tag: v20.1.0.0~120
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=45c6d160b65d03b2d5d30b8b74177b135729c99e;p=gem5.git

python: Remove unused debug APIs

The following APIs are not exported from the _m5 namespace and not
used by any of the debug glue code:

 * m5.debug.findFlag
 * m5.debug.setDebugFlag
 * m5.debug.clearDebugFlag
 * m5.debug.dumpDebugFlags

All of them have a clean Python interface where flags are exported
using the m5.debug.flags dictionary. There is also an m5.debug.help
function that lists the available debug flags.

Remove the unused APIs to avoid confusion.

Change-Id: I74738451eb5874f83b135adaccd30a0c6b478996
Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-on: https://gem5-review.googlesource.com/c/public/gem5/+/34120
Reviewed-by: Jason Lowe-Power <power.jg@gmail.com>
Reviewed-by: Gabe Black <gabeblack@google.com>
Maintainer: Jason Lowe-Power <power.jg@gmail.com>
Tested-by: kokoro <noreply+kokoro@google.com>
---

diff --git a/src/python/pybind11/debug.cc b/src/python/pybind11/debug.cc
index 69c497c1d..84673f1f3 100644
--- a/src/python/pybind11/debug.cc
+++ b/src/python/pybind11/debug.cc
@@ -83,10 +83,6 @@ pybind_init_debug(py::module &m_native)
     m_debug
         .def("getAllFlagsVersion", []() { return Debug::allFlagsVersion; })
         .def("allFlags", &Debug::allFlags, py::return_value_policy::reference)
-        .def("findFlag", &Debug::findFlag)
-        .def("setDebugFlag", &setDebugFlag)
-        .def("clearDebugFlag", &clearDebugFlag)
-        .def("dumpDebugFlags", &dumpDebugFlags)
 
         .def("schedBreak", &schedBreak)
         .def("setRemoteGDBPort", &setRemoteGDBPort)