From: Simon Marchi <simon.marchi@efficios.com>
Date: Mon, 24 Oct 2022 20:16:09 +0000 (-0400)
Subject: gdb: use frame_id_p instead of comparing to null_frame_id in frame_info_ptr::reinflate
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=45eca9d9f36985672cb2303b4ea0b3c855961c1d;p=binutils-gdb.git

gdb: use frame_id_p instead of comparing to null_frame_id in frame_info_ptr::reinflate

The assertion

    gdb_assert (m_cached_id != null_frame_id);

is always true, as comparing equal to null_frame_id is always false
(it's the first case in frame_id::operator==, not sure why it's not this
way, but that's what it is).

Replace the comparison with a call to frame_id_p.

Approved-By: Tom Tromey <tom@tromey.com>
Change-Id: I93986e6a85ac56353690792552e5b3b4cedec7fb
---

diff --git a/gdb/frame-info.c b/gdb/frame-info.c
index 84791205d90..584222dc490 100644
--- a/gdb/frame-info.c
+++ b/gdb/frame-info.c
@@ -39,7 +39,7 @@ frame_info_ptr::prepare_reinflate ()
 void
 frame_info_ptr::reinflate ()
 {
-  gdb_assert (m_cached_id != null_frame_id);
+  gdb_assert (frame_id_p (m_cached_id));
 
   if (m_ptr == nullptr)
     m_ptr = frame_find_by_id (m_cached_id).get ();