From: Pedro Alves <palves@redhat.com>
Date: Fri, 19 Apr 2013 15:22:14 +0000 (+0000)
Subject: ppc-linux-tdep.c: Wrong signness for buffer holding instructions.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=463920bf28e3aea7ebac2cf10b8e5b98e56400eb;p=binutils-gdb.git

ppc-linux-tdep.c: Wrong signness for buffer holding instructions.

There seems to be no reason for this buffer to be signed.  We pass it
around to functions expecting it to be unsigned (which triggers
-Wpointer-sign warnings).

gdb/
2013-04-19  Pedro Alves  <palves@redhat.com>

	* ppc-linux-tdep.c (ppc_skip_trampoline_code): Change local
	'insnbuf' buffer type to unsigned int[].
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index 9314749344f..f71ebc64045 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2013-04-19  Pedro Alves  <palves@redhat.com>
+
+	* ppc-linux-tdep.c (ppc_skip_trampoline_code): Change local
+	'insnbuf' buffer type to unsigned int[].
+
 2013-04-19  Pedro Alves  <palves@redhat.com>
 
 	* mips-tdep.c (mips_read_pc): Change local 'pc' type to LONGEST.
diff --git a/gdb/ppc-linux-tdep.c b/gdb/ppc-linux-tdep.c
index 6895562a782..25b6c0b9102 100644
--- a/gdb/ppc-linux-tdep.c
+++ b/gdb/ppc-linux-tdep.c
@@ -355,7 +355,7 @@ powerpc_linux_in_dynsym_resolve_code (CORE_ADDR pc)
 static CORE_ADDR
 ppc_skip_trampoline_code (struct frame_info *frame, CORE_ADDR pc)
 {
-  int insnbuf[POWERPC32_PLT_STUB_LEN];
+  unsigned int insnbuf[POWERPC32_PLT_STUB_LEN];
   struct gdbarch *gdbarch = get_frame_arch (frame);
   struct gdbarch_tdep *tdep = gdbarch_tdep (gdbarch);
   enum bfd_endian byte_order = gdbarch_byte_order (gdbarch);