From: Simon Marchi <simon.marchi@ericsson.com>
Date: Thu, 8 Mar 2018 22:54:25 +0000 (-0500)
Subject: remote-stdio-gdbserver: Pass "target" to remote_exec to delete file
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4872dc464db25a003c66ef91773b616495cc504f;p=binutils-gdb.git

remote-stdio-gdbserver: Pass "target" to remote_exec to delete file

As described here

  https://sourceware.org/bugzilla/show_bug.cgi?id=22841

there seems to be situations where the remote-stdio-gdbserver board
fails to delete the uploaded binary file.  Passing "target" fixes the
issue for Christian who reported the bug.

I did not experience this problem, but passing "target" to remote_exec
still works for me, so I'm fine with changing it.

Any objection?

gdb/testsuite/ChangeLog:

	PR gdb/22841
	* boards/remote-stdio-gdbserver.exp (${board}_file): Pass
	"target" to remote_exec.
---

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 1aeb785131a..c24ae5fb20a 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,9 @@
+2018-03-08  Simon Marchi  <simon.marchi@ericsson.com>
+
+	PR gdb/22841
+	* boards/remote-stdio-gdbserver.exp (${board}_file): Pass
+	"target" to remote_exec.
+
 2018-03-08  Simon Marchi  <simon.marchi@polymtl.ca>
 
 	PR gdb/22841
diff --git a/gdb/testsuite/boards/remote-stdio-gdbserver.exp b/gdb/testsuite/boards/remote-stdio-gdbserver.exp
index aff7902f438..d559b85313d 100644
--- a/gdb/testsuite/boards/remote-stdio-gdbserver.exp
+++ b/gdb/testsuite/boards/remote-stdio-gdbserver.exp
@@ -75,7 +75,7 @@ proc get_target_remote_pipe_cmd { } {
 
 proc ${board}_file { dest op args } {
     if { $op == "delete" } {
-	return [remote_exec [get_remote_login] "rm -f $args"]
+	return [remote_exec target "rm -f $args"]
     }
     return [eval [list standard_file $dest $op] $args]
 }