From: Roland Scheidegger <sroland@vmware.com>
Date: Tue, 24 Mar 2020 20:56:40 +0000 (+0100)
Subject: gallivm: disable rgtc/latc SNORM accellerated fetches
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4897e70ccd3987d470ec8622d473ee3405f6e96f;p=mesa.git

gallivm: disable rgtc/latc SNORM accellerated fetches

Unfortunately this appears to be bugged (it seems the piglit tests aren't
quite exhaustive enough). I'm almost certain it's the lerp
(lp_build_lerpdxta()) which doesn't handle signed numbers correctly, let's
disable for now.

Reviewed-by: Dave Airlie <airlied@redhat.com>
Tested-by: Marge Bot <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4311>
Part-of: <https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4311>
---

diff --git a/src/gallium/auxiliary/gallivm/lp_bld_format_aos.c b/src/gallium/auxiliary/gallivm/lp_bld_format_aos.c
index f8e1a963bb4..781ceb8b03d 100644
--- a/src/gallium/auxiliary/gallivm/lp_bld_format_aos.c
+++ b/src/gallium/auxiliary/gallivm/lp_bld_format_aos.c
@@ -770,19 +770,25 @@ lp_build_fetch_rgba_aos(struct gallivm_state *gallivm,
                        format_desc->format == PIPE_FORMAT_LATC1_SNORM ||
                        format_desc->format == PIPE_FORMAT_LATC2_SNORM);
 
-      tmp = lp_build_fetch_rgtc_rgba_aos(gallivm,
-                                         format_desc,
-                                         num_pixels,
-                                         base_ptr,
-                                         offset,
-                                         i, j,
-                                         cache);
-
-      lp_build_conv(gallivm,
-                    tmp_type, type,
-                    &tmp, 1, &tmp, 1);
-
-       return tmp;
+      if (!tmp_type.sign) {
+         /*
+          * FIXME: this is buggy for snorm formats, likely the lerp is
+          * busted.
+          */
+         tmp = lp_build_fetch_rgtc_rgba_aos(gallivm,
+                                            format_desc,
+                                            num_pixels,
+                                            base_ptr,
+                                            offset,
+                                            i, j,
+                                            cache);
+
+         lp_build_conv(gallivm,
+                       tmp_type, type,
+                       &tmp, 1, &tmp, 1);
+
+         return tmp;
+      }
    }
 
    /*