From: Alan Modra <amodra@gmail.com>
Date: Sun, 23 Jun 2002 12:44:31 +0000 (+0000)
Subject: 	* elflink.h (elf_link_add_archive_symbols): For the default
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=48fc70a2b6e21524a3526d8d028875689ecc72eb;p=binutils-gdb.git

	* elflink.h (elf_link_add_archive_symbols): For the default
	version, check references with only one `@' first.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 02c0ef1887d..23c68b198c1 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2002-06-23  H.J. Lu  <hjl@gnu.org>
+
+	* elflink.h (elf_link_add_archive_symbols): For the default
+	version, check references with only one `@' first.
+
 2002-06-23  John David Anglin  <dave@hiauly1.hia.nrc.ca>
 
 	* elf64-hppa.c (elf64_hppa_mark_milli_and_exported_functions): New
diff --git a/bfd/elflink.h b/bfd/elflink.h
index 3cd9e0c49aa..d4a26528a9e 100644
--- a/bfd/elflink.h
+++ b/bfd/elflink.h
@@ -353,26 +353,40 @@ elf_link_add_archive_symbols (abfd, info)
 	  if (h == NULL)
 	    {
 	      char *p, *copy;
+	      size_t len, first;
 
 	      /* If this is a default version (the name contains @@),
-		 look up the symbol again without the version.  The
-		 effect is that references to the symbol without the
-		 version will be matched by the default symbol in the
-		 archive.  */
+		 look up the symbol again with only one `@' as well
+		 as without the version.  The effect is that references
+		 to the symbol with and without the version will be
+		 matched by the default symbol in the archive.  */
 
 	      p = strchr (symdef->name, ELF_VER_CHR);
 	      if (p == NULL || p[1] != ELF_VER_CHR)
 		continue;
 
-	      copy = bfd_alloc (abfd, (bfd_size_type) (p - symdef->name + 1));
+	      /* First check with only one `@'.  */
+	      len = strlen (symdef->name);
+	      copy = bfd_alloc (abfd, (bfd_size_type) len);
 	      if (copy == NULL)
 		goto error_return;
-	      memcpy (copy, symdef->name, (size_t) (p - symdef->name));
-	      copy[p - symdef->name] = '\0';
+	      first = p - symdef->name + 1;
+	      memcpy (copy, symdef->name, first);
+	      memcpy (copy + first, symdef->name + first + 1, len - first);
 
 	      h = elf_link_hash_lookup (elf_hash_table (info), copy,
 					false, false, false);
 
+	      if (h == NULL)
+	        {
+		  /* We also need to check references to the symbol
+		     without the version.  */
+
+		  copy[first - 1] = '\0';
+		  h = elf_link_hash_lookup (elf_hash_table (info),
+					    copy, false, false, false);
+		}
+
 	      bfd_release (abfd, copy);
 	    }