From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date: Sun, 31 May 2020 18:46:44 +0000 (+0100)
Subject: imports - use of globals. baaaad
X-Git-Tag: div_pipeline~707
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=49dd3b803d8baee268321a76a03c2b4e6accdae9;p=soc.git

imports - use of globals. baaaad
---

diff --git a/src/soc/fu/compunits/test/test_alu_compunit.py b/src/soc/fu/compunits/test/test_alu_compunit.py
index 6041cd3e..f81aa736 100644
--- a/src/soc/fu/compunits/test/test_alu_compunit.py
+++ b/src/soc/fu/compunits/test/test_alu_compunit.py
@@ -1,7 +1,10 @@
 import unittest
 from soc.decoder.power_enums import (XER_bits,)
 
-from soc.fu.alu.test.test_pipe_caller import TestCase, ALUTestCase, test_data
+# XXX bad practice: use of global variables
+from soc.fu.alu.test.test_pipe_caller import ALUTestCase # creates the tests
+from soc.fu.alu.test.test_pipe_caller import test_data # imports the data
+
 from soc.fu.compunits.compunits import ALUFunctionUnit
 from soc.fu.compunits.test.test_compunit import TestRunner