From: Daniel Benusovich <flyingmonkeys1996@gmail.com>
Date: Wed, 20 Mar 2019 04:56:37 +0000 (-0700)
Subject: Update PermissionValidator to use PteEntry Parser to increase code read ability and... 
X-Git-Tag: div_pipeline~2288
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4a4fa5ec4a49dfaa3f7c7ea7005c0144456fcf1f;p=soc.git

Update PermissionValidator to use PteEntry Parser to increase code read ability and code duplication
---

diff --git a/TLB/src/PermissionValidator.py b/TLB/src/PermissionValidator.py
index c9483914..14f01e42 100644
--- a/TLB/src/PermissionValidator.py
+++ b/TLB/src/PermissionValidator.py
@@ -1,6 +1,8 @@
 from nmigen import Module, Signal
 from nmigen.cli import main
 
+from PteEntry import PteEntry
+
 class PermissionValidator():
     """ The purpose of this Module is to check the Permissions of a given PTE
         against the requested access permissions.
@@ -10,15 +12,19 @@ class PermissionValidator():
         the valid bit LOW) the request
     """
 
-    def __init__(self, data_size):
+    def __init__(self, asid_size, pte_size):
         """ Arguments:
-            * data_size: (bit count) The size of the data words being processed
+            * asid_size: (bit count) The size of the asid to be processed
+            * pte_size: (bit count) The size of the pte to be processed
 
             Return:
             * valid HIGH when permissions are correct
         """
+        # Internal
+        self.pte_entry = PteEntry(asid_size, pte_size)
+
         # Input
-        self.data = Signal(data_size);
+        self.data = Signal(asid_size + pte_size);
         self.xwr = Signal(3) # Execute, Write, Read
         self.super_mode = Signal(1) # Supervisor Mode
         self.super_access = Signal(1) # Supervisor Access
@@ -29,25 +35,29 @@ class PermissionValidator():
 
     def elaborate(self, platform=None):
         m = Module()
+
+        m.submodules.pte_entry = self.pte_entry
+
+        m.d.comb += self.pte_entry.i.eq(self.data)
+
         # Check if the entry is valid
-        with m.If(self.data[0]):
+        with m.If(self.pte_entry.v):
             # ASID match or Global Permission
             # Note that the MSB bound is exclusive
-            with m.If((self.data[64:79] == self.asid) | self.data[5]):
+            with m.If((self.pte_entry.asid == self.asid) | self.pte_entry.g):
                 # Check Execute, Write, Read (XWR) Permissions
-                with m.If((self.data[3] == self.xwr[2]) \
-                          & (self.data[2] == self.xwr[1]) \
-                          & (self.data[1] == self.xwr[0])):
+                with m.If(self.pte_entry.xwr == self.xwr):
                     # Supervisor Logic
                     with m.If(self.super_mode):
                         # Valid if entry is not in user mode or supervisor
                         # has Supervisor User Memory (SUM) access via the
                         # SUM bit in the sstatus register
-                        m.d.comb += self.valid.eq((~self.data[4]) | self.super_access)
+                        m.d.comb += self.valid.eq((~self.pte_entry.u) \
+                                                  | self.super_access)
                     # User logic
                     with m.Else():
                         # Valid if the entry is in user mode only
-                        m.d.comb += self.valid.eq(self.data[4])
+                        m.d.comb += self.valid.eq(self.pte_entry.u)
                 with m.Else():
                     m.d.comb += self.valid.eq(0)
             with m.Else():
diff --git a/TLB/test/test_permission_validator.py b/TLB/test/test_permission_validator.py
index 0b6e96f6..59750c51 100644
--- a/TLB/test/test_permission_validator.py
+++ b/TLB/test/test_permission_validator.py
@@ -140,6 +140,6 @@ def testbench(dut):
     yield from check_valid(dut, valid, 0)
 
 if __name__ == "__main__":
-    dut = PermissionValidator(64 + 15);
+    dut = PermissionValidator(15, 64);
     run_simulation(dut, testbench(dut), vcd_name="Waveforms/test_permission_validator.vcd")
     print("PermissionValidator Unit Test Success")