From: Nick Clifton <nickc@redhat.com>
Date: Wed, 1 Aug 2018 13:42:37 +0000 (+0100)
Subject: Fix potential illegal memory access in AVR backend.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4a9f7d653c089fdd8ca66a51caab7c9687f50cd1;p=binutils-gdb.git

Fix potential illegal memory access in AVR backend.

	* elf32-avr.c (avr_stub_name): Check for a NULL return from
	bfd_malloc.
---

diff --git a/bfd/ChangeLog b/bfd/ChangeLog
index 117a8dbdcac..59b72666873 100644
--- a/bfd/ChangeLog
+++ b/bfd/ChangeLog
@@ -1,3 +1,8 @@
+2018-08-01  Nick Clifton  <nickc@redhat.com>
+
+	* elf32-avr.c (avr_stub_name): Check for a NULL return from
+	bfd_malloc.
+
 2018-08-01  Zenith  <zenith432@users.sourceforge.net>
 
 	PR 23460
diff --git a/bfd/elf32-avr.c b/bfd/elf32-avr.c
index 7087606c935..6d38d1db3af 100644
--- a/bfd/elf32-avr.c
+++ b/bfd/elf32-avr.c
@@ -3295,10 +3295,10 @@ avr_stub_name (const asection *symbol_section,
 
   len = 8 + 1 + 8 + 1 + 1;
   stub_name = bfd_malloc (len);
-
-  sprintf (stub_name, "%08x+%08x",
-	   symbol_section->id & 0xffffffff,
-	   (unsigned int) ((rela->r_addend & 0xffffffff) + symbol_offset));
+  if (stub_name != NULL)
+    sprintf (stub_name, "%08x+%08x",
+	     symbol_section->id & 0xffffffff,
+	     (unsigned int) ((rela->r_addend & 0xffffffff) + symbol_offset));
 
   return stub_name;
 }