From: Ville Voutilainen Date: Mon, 19 Dec 2016 12:55:33 +0000 (+0200) Subject: Make the perfect-forwarding constructor of a two-element tuple sfinae away when the... X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4b21c3ea03540ba1d89bca16561820f0911e17ce;p=gcc.git Make the perfect-forwarding constructor of a two-element tuple sfinae away when the first argument is an allocator_arg. Make the perfect-forwarding constructor of a two-element tuple sfinae away when the first argument is an allocator_arg. * include/std/tuple (tuple(_U1&&, _U2&&)): Constrain. * testsuite/20_util/tuple/cons/allocator_with_any.cc: New. * testsuite/20_util/tuple/element_access/get_neg.cc: Adjust. From-SVN: r243795 --- diff --git a/libstdc++-v3/ChangeLog b/libstdc++-v3/ChangeLog index 0fc7832dc94..28f2f802d80 100644 --- a/libstdc++-v3/ChangeLog +++ b/libstdc++-v3/ChangeLog @@ -1,3 +1,11 @@ +2016-12-19 Ville Voutilainen + + Make the perfect-forwarding constructor of a two-element tuple + sfinae away when the first argument is an allocator_arg. + * include/std/tuple (tuple(_U1&&, _U2&&)): Constrain. + * testsuite/20_util/tuple/cons/allocator_with_any.cc: New. + * testsuite/20_util/tuple/element_access/get_neg.cc: Adjust. + 2016-12-16 Jonathan Wakely * include/bits/stl_map.h (map::erase(iterator)): Add Doxygen markup diff --git a/libstdc++-v3/include/std/tuple b/libstdc++-v3/include/std/tuple index 13e0bf8e3cf..9dbdd8dc98f 100644 --- a/libstdc++-v3/include/std/tuple +++ b/libstdc++-v3/include/std/tuple @@ -951,7 +951,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION enable_if<_TMC::template _MoveConstructibleTuple<_U1, _U2>() && _TMC::template - _ImplicitlyMoveConvertibleTuple<_U1, _U2>(), + _ImplicitlyMoveConvertibleTuple<_U1, _U2>() + && !is_same::type, + allocator_arg_t>::value, bool>::type = true> constexpr tuple(_U1&& __a1, _U2&& __a2) : _Inherited(std::forward<_U1>(__a1), std::forward<_U2>(__a2)) { } @@ -960,7 +962,9 @@ _GLIBCXX_BEGIN_NAMESPACE_VERSION enable_if<_TMC::template _MoveConstructibleTuple<_U1, _U2>() && !_TMC::template - _ImplicitlyMoveConvertibleTuple<_U1, _U2>(), + _ImplicitlyMoveConvertibleTuple<_U1, _U2>() + && !is_same::type, + allocator_arg_t>::value, bool>::type = false> explicit constexpr tuple(_U1&& __a1, _U2&& __a2) : _Inherited(std::forward<_U1>(__a1), std::forward<_U2>(__a2)) { } diff --git a/libstdc++-v3/testsuite/20_util/tuple/cons/allocator_with_any.cc b/libstdc++-v3/testsuite/20_util/tuple/cons/allocator_with_any.cc new file mode 100644 index 00000000000..9f86c93e378 --- /dev/null +++ b/libstdc++-v3/testsuite/20_util/tuple/cons/allocator_with_any.cc @@ -0,0 +1,42 @@ +// { dg-do run { target c++14 } } + +// Copyright (C) 2016 Free Software Foundation, Inc. +// +// This file is part of the GNU ISO C++ Library. This library is free +// software; you can redistribute it and/or modify it under the +// terms of the GNU General Public License as published by the +// Free Software Foundation; either version 3, or (at your option) +// any later version. + +// This library is distributed in the hope that it will be useful, +// but WITHOUT ANY WARRANTY; without even the implied warranty of +// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +// GNU General Public License for more details. + +// You should have received a copy of the GNU General Public License along +// with this library; see the file COPYING3. If not see +// . + + +// NOTE: This makes use of the fact that we know how moveable +// is implemented on tuple. If the implementation changed +// this test may begin to fail. + +#include +#include +#include + +using std::experimental::any; + +void test01() +{ + std::tuple t(std::allocator_arg, + std::allocator{}); + VERIFY(std::get<0>(t).empty()); + VERIFY(std::get<1>(t).empty()); +} + +int main() +{ + test01(); +} diff --git a/libstdc++-v3/testsuite/20_util/tuple/element_access/get_neg.cc b/libstdc++-v3/testsuite/20_util/tuple/element_access/get_neg.cc index 5bcf5761c36..7da61e589fe 100644 --- a/libstdc++-v3/testsuite/20_util/tuple/element_access/get_neg.cc +++ b/libstdc++-v3/testsuite/20_util/tuple/element_access/get_neg.cc @@ -17,7 +17,7 @@ // { dg-options "-fno-show-column" } // { dg-do compile { target c++14 } } -// { dg-error "in range" "" { target *-*-* } 1280 } +// { dg-error "in range" "" { target *-*-* } 1284 } #include