From: Nathan Sidwell <nathan@codesourcery.com>
Date: Mon, 29 Apr 2002 08:47:31 +0000 (+0000)
Subject: re PR c++/5719 (Suspect gcc-3 to report wrong waring for 'T& T::operator+=( const... 
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4bd7c27025afa9f79d44b053a84ca96f110787b7;p=gcc.git

re PR c++/5719 (Suspect gcc-3 to report wrong waring for 'T& T::operator+=( const T& )')

cp:
	PR c++/5719
	* decl.c (grok_op_properties): Assignment ops don't have to return
	by value. operator% should.
testsuite:
	* g++.dg/warn/effc1.C: New test.

From-SVN: r52888
---

diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog
index 61673813fd7..e076a34a443 100644
--- a/gcc/cp/ChangeLog
+++ b/gcc/cp/ChangeLog
@@ -1,3 +1,9 @@
+2002-04-29  Nathan Sidwell  <nathan@codesourcery.com>
+
+	PR c++/5719
+	* decl.c (grok_op_properties): Assignment ops don't have to return 
+	by value. operator% should.
+
 2002-04-28  Franz Sirl  <Franz.Sirl-kernel@lauterbach.com>
 
 	PR c/6343
diff --git a/gcc/cp/decl.c b/gcc/cp/decl.c
index 642fcf019d0..450bc3988a8 100644
--- a/gcc/cp/decl.c
+++ b/gcc/cp/decl.c
@@ -12677,10 +12677,12 @@ grok_op_properties (decl, friendp)
       /* Effective C++ rule 23.  */
       if (warn_ecpp
 	  && arity == 2
+	  && !DECL_ASSIGNMENT_OPERATOR_P (decl)
 	  && (operator_code == PLUS_EXPR
 	      || operator_code == MINUS_EXPR
 	      || operator_code == TRUNC_DIV_EXPR
-	      || operator_code == MULT_EXPR)
+	      || operator_code == MULT_EXPR
+	      || operator_code == TRUNC_MOD_EXPR)
 	  && TREE_CODE (TREE_TYPE (TREE_TYPE (decl))) == REFERENCE_TYPE)
 	warning ("`%D' should return by value", decl);
 
diff --git a/gcc/testsuite/ChangeLog b/gcc/testsuite/ChangeLog
index f806315491b..0024a921211 100644
--- a/gcc/testsuite/ChangeLog
+++ b/gcc/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2002-04-29  Nathan Sidwell  <nathan@codesourcery.com>
+
+	* g++.dg/warn/effc1.C: New test.
+
 2002-04-29  Neil Booth  <neil@daikokuya.demon.co.uk>
 
 	* gcc.dg/cpp/if-cexp.c: Add a test.
diff --git a/gcc/testsuite/g++.dg/warn/effc1.C b/gcc/testsuite/g++.dg/warn/effc1.C
new file mode 100644
index 00000000000..e90c5f7812f
--- /dev/null
+++ b/gcc/testsuite/g++.dg/warn/effc1.C
@@ -0,0 +1,16 @@
+// { dg-options -Weffc++ }
+// { dg-do compile }
+
+// Copyright (C) 2001 Free Software Foundation, Inc.
+// Contributed by Nathan Sidwell 26 Apr 2002 <nathan@codesourcery.com>
+
+// Bug 5719 
+
+class A
+{
+  public:
+  A & operator+=( int );
+  A & operator+( int ); // { dg-warning "`A& A::operator+(int)' should return by value" "" }
+  A operator+=( float );
+  A operator+( float );
+};