From: WANG Xuerui Date: Sun, 2 Jul 2023 10:14:22 +0000 (+0800) Subject: LoongArch: gas: Fix shared builds X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4bf2114b634413e224c990593455168b873519d9;p=binutils-gdb.git LoongArch: gas: Fix shared builds Formerly an include of libbfd.h was added in commit 56576f4a722 ("LoongArch: gas: Add support for linker relaxation."), in order to allow calling _bfd_read_unsigned_leb128 from gas, but doing so broke shared builds. Commit d2fddb6d783 fixed this reference but did not remove the now unnecessary inclusion of libbfd.h. The gas_assert macro expands into a conditional call to abort(), but "abort" is re-defined to _bfd_abort in libbfd.h, so the extra include breaks any gas_assert usage, and should be removed. gas/ChangeLog: * config/tc-loongarch.c: Don't include libbfd.h. Fixes: d2fddb6d783 ("LoongArch: Fix ld "undefined reference" error with --enable-shared") Signed-off-by: WANG Xuerui --- diff --git a/gas/config/tc-loongarch.c b/gas/config/tc-loongarch.c index 439bde18b7d..2e8a259d147 100644 --- a/gas/config/tc-loongarch.c +++ b/gas/config/tc-loongarch.c @@ -31,7 +31,6 @@ #include #include #include -#include "libbfd.h" /* All information about an instruction during assemble. */ struct loongarch_cl_insn