From: Cole Poirier <colepoirier@gmail.com>
Date: Tue, 25 Aug 2020 00:47:41 +0000 (-0700)
Subject: dcache.py move MemAccessRequest RecordObject to top of file, small
X-Git-Tag: semi_working_ecp5~260
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4ce39cc96b696b8ad6d6f10761d5202972db1a1d;p=soc.git

dcache.py move MemAccessRequest RecordObject to top of file, small
formatting changes
---

diff --git a/src/soc/experiment/dcache.py b/src/soc/experiment/dcache.py
index 31885f93..a5264ded 100644
--- a/src/soc/experiment/dcache.py
+++ b/src/soc/experiment/dcache.py
@@ -19,9 +19,10 @@ from experiment.mem_types import LoadStore1ToDcacheType,
 
 from experiment.wb_types import WB_ADDR_BITS, WB_DATA_BITS, WB_SEL_BITS,
                                 WBAddrType, WBDataType, WBSelType,
-                                WbMasterOut, WBSlaveOut, WBMasterOutVector,
-                                WBSlaveOutVector, WBIOMasterOut,
-                                WBIOSlaveOut
+                                WbMasterOut, WBSlaveOut,
+                                WBMasterOutVector, WBSlaveOutVector,
+                                WBIOMasterOut, WBIOSlaveOut
+
 
 # Record for storing permission, attribute, etc. bits from a PTE
 class PermAttr(RecordObject):
@@ -58,6 +59,7 @@ class Op(Enum):
     OP_STORE_HIT  = 6 # Store hitting cache
     OP_STORE_MISS = 7 # Store missing cache
 
+
 # Cache state machine
 @unique
 class State(Enum):
@@ -66,6 +68,7 @@ class State(Enum):
     STORE_WAIT_ACK   = 2 # Store wait ack
     NC_LOAD_WAIT_ACK = 3 # Non-cachable load wait ack
 
+
 # Dcache operations:
 #
 # In order to make timing, we use the BRAMs with
@@ -91,17 +94,29 @@ class RegStage0(RecordObject):
         self.tlbld   = Signal()
         self.mmu_req = Signal() # indicates source of request
 
-# --
-# -- Set associative dcache write-through
-# --
-# -- TODO (in no specific order):
-# --
-# -- * See list in icache.vhdl
-# -- * Complete load misses on the cycle when WB data comes instead of
-# --   at the end of line (this requires dealing with requests coming in
-# --   while not idle...)
-# --
 
+class MemAccessRequest(RecordObject):
+    def __init__(self):
+        super().__init__()
+        self.op        = Op()
+        self.valid     = Signal()
+        self.dcbz      = Signal()
+        self.real_addr = Signal(REAL_ADDR_BITS)
+        self.data      = Signal(64)
+        self.byte_sel  = Signal(8)
+        self.hit_way   = Signal(WAY_BITS)
+        self.same_tag  = Signal()
+        self.mmu_req   = Signal()
+
+
+# Set associative dcache write-through
+#
+# TODO (in no specific order):
+#
+# * See list in icache.vhdl
+# * Complete load misses on the cycle when WB data comes instead of
+#   at the end of line (this requires dealing with requests coming in
+#   while not idle...)
 class Dcache(Elaboratable):
     def __init__(self):
         # TODO: make these parameters of Dcache at some point
@@ -369,29 +384,6 @@ class Dcache(Elaboratable):
         r0      = RegStage0()
         r0_full = Signal()
 
-#     type mem_access_request_t is record
-#         op        : op_t;
-#         valid     : std_ulogic;
-#         dcbz      : std_ulogic;
-#         real_addr : std_ulogic_vector(REAL_ADDR_BITS - 1 downto 0);
-#         data      : std_ulogic_vector(63 downto 0);
-#         byte_sel  : std_ulogic_vector(7 downto 0);
-#         hit_way   : way_t;
-#         same_tag  : std_ulogic;
-#         mmu_req   : std_ulogic;
-#     end record;
-        class MemAccessRequest(RecordObject):
-            def __init__(self):
-                super().__init__()
-                self.op        = Op()
-                self.valid     = Signal()
-                self.dcbz      = Signal()
-                self.real_addr = Signal(REAL_ADDR_BITS)
-                self.data      = Signal(64)
-                self.byte_sel  = Signal(8)
-                self.hit_way   = Signal(WAY_BITS)
-                self.same_tag  = Signal()
-                self.mmu_req   = Signal()
 
 #     -- First stage register, contains state for stage 1 of load hits
 #     -- and for the state machine used by all other operations