From: Alex Smith Date: Wed, 12 Jul 2017 10:14:21 +0000 (+0100) Subject: radv: Fix possible invalid free of dynamic descriptors X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4d5c0c189d43e7ebf880d7994a09118051d69e97;p=mesa.git radv: Fix possible invalid free of dynamic descriptors This free was left in after dynamic descriptors were changed to not be allocated separately from the descriptor set, and can cause a crash. Fixes: 39644fa40a3 ("radv: Don't allocate dynamic descriptors separately") Signed-off-by: Alex Smith Reviewed-by: Bas Nieuwenhuizen --- diff --git a/src/amd/vulkan/radv_descriptor_set.c b/src/amd/vulkan/radv_descriptor_set.c index ec7fd3d8cc8..b482843539d 100644 --- a/src/amd/vulkan/radv_descriptor_set.c +++ b/src/amd/vulkan/radv_descriptor_set.c @@ -317,7 +317,6 @@ radv_descriptor_set_create(struct radv_device *device, } if (pool->size - offset < layout_size) { - vk_free2(&device->alloc, NULL, set->dynamic_descriptors); vk_free2(&device->alloc, NULL, set); return vk_error(VK_ERROR_OUT_OF_POOL_MEMORY_KHR); }