From: Lancelot SIX <lsix@lancelotsix.com>
Date: Tue, 23 Nov 2021 16:40:24 +0000 (+0000)
Subject: gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4df98d9d31173d45438fbf000e6ed2d3cdd98ae2;p=binutils-gdb.git

gdb/testsuite: Remove duplicates from gdb.threads/staticthreads.ex

When running the testsuite, I have:

    Running .../gdb/testsuite/gdb.threads/staticthreads.exp ...
    DUPLICATE: gdb.threads/staticthreads.exp: couldn't compile staticthreads.c: unrecognized error

Fix by using foreach_with_prefix instead of foreach when preparing the
test case.

Testeed on x86_64-linux both in a setup where the test fails to prepare
and in a setup where the test fails to setup.
---

diff --git a/gdb/testsuite/gdb.threads/staticthreads.exp b/gdb/testsuite/gdb.threads/staticthreads.exp
index cc4867dd459..788fb53b21b 100644
--- a/gdb/testsuite/gdb.threads/staticthreads.exp
+++ b/gdb/testsuite/gdb.threads/staticthreads.exp
@@ -22,7 +22,7 @@
 standard_testfile
 set static_flag "-static"
 
-foreach have_tls { "-DHAVE_TLS" "" } {
+foreach_with_prefix have_tls { "-DHAVE_TLS" "" } {
     if {[gdb_compile_pthreads "${srcdir}/${subdir}/${srcfile}" "${binfile}" \
 	     executable \
 	     [list debug "additional_flags=${static_flag} ${have_tls}" \