From: Daniel Berlin <dberlin@dberlin.org>
Date: Sun, 1 Apr 2001 19:50:50 +0000 (+0000)
Subject: 2001-03-20  Daniel Berlin  <dberlin@redhat.com>
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4e4f46a17d11ba5023cc11d18a8fb01ecc1e7fae;p=binutils-gdb.git

2001-03-20  Daniel Berlin  <dberlin@redhat.com>

	* symtab.c (completion_list_add_name): Remove duplicate string checks,
	readline already does this, and it's much faster at it, too.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index eef27f309f0..acba6c29e00 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2001-03-20  Daniel Berlin  <dberlin@redhat.com>
+	
+	* symtab.c (completion_list_add_name): Remove duplicate string checks,
+	readline already does this, and it's much faster at it, too.
+
 2001-04-01  Eli Zaretskii  <eliz@is.elta.co.il>
 
 	* go32-nat.c: Minor tweaks, to pacify the ari script.
diff --git a/gdb/symtab.c b/gdb/symtab.c
index a51126a1d8c..6cb8e963de4 100644
--- a/gdb/symtab.c
+++ b/gdb/symtab.c
@@ -2844,17 +2844,6 @@ completion_list_add_name (char *symname, char *sym_text, int sym_text_len,
       return;
     }
 
-  /* Clip any symbol names that we've already considered.  (This is a
-     time optimization)  */
-
-  for (i = 0; i < return_val_index; ++i)
-    {
-      if (STREQ (symname, return_val[i]))
-	{
-	  return;
-	}
-    }
-
   /* We have a match for a completion, so add SYMNAME to the current list
      of matches. Note that the name is moved to freshly malloc'd space. */
 
@@ -2880,19 +2869,6 @@ completion_list_add_name (char *symname, char *sym_text, int sym_text_len,
 	strcat (new, symname);
       }
 
-    /* Recheck for duplicates if we intend to add a modified symbol.  */
-    if (word != sym_text)
-      {
-	for (i = 0; i < return_val_index; ++i)
-	  {
-	    if (STREQ (new, return_val[i]))
-	      {
-		xfree (new);
-		return;
-	      }
-	  }
-      }
-
     if (return_val_index + 3 > return_val_size)
       {
 	newsize = (return_val_size *= 2) * sizeof (char *);