From: Chad Versace <chad.versace@intel.com>
Date: Mon, 5 Oct 2015 20:17:39 +0000 (-0700)
Subject: vk/image: Document a Vulkan spec requirement for depthstencil
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=4ffb4549e0aa139c908afd3c1b05e9a3ca6acf40;p=mesa.git

vk/image: Document a Vulkan spec requirement for depthstencil

The Vulkan spec (git a511ba2) requires support for some combined depth
stencil formats.
---

diff --git a/src/vulkan/anv_image.c b/src/vulkan/anv_image.c
index 2045aa27219..43245297f0e 100644
--- a/src/vulkan/anv_image.c
+++ b/src/vulkan/anv_image.c
@@ -546,9 +546,11 @@ anv_image_get_surface_for_aspect_mask(struct anv_image *image, VkImageAspectFlag
       anv_finishme("stencil image views");
       return &image->stencil_surface;
    case VK_IMAGE_ASPECT_DEPTH_BIT | VK_IMAGE_ASPECT_STENCIL_BIT:
-      /* FINISHME: Support combined depthstencil aspect. Does the Vulkan spec
-       * allow is to reject it? Until we support it, filter out the stencil
-       * aspect and use only the depth aspect.
+      /* FINISHME: The Vulkan spec (git a511ba2) requires support for combined
+       * depth stencil formats. Specifically, it states:
+       *
+       *    At least one of ename:VK_FORMAT_D24_UNORM_S8_UINT or
+       *    ename:VK_FORMAT_D32_SFLOAT_S8_UINT must be supported.
        */
       anv_finishme("combined depthstencil aspect");
       assert(image->format->depth_format);