From: Luca Ceresoli Date: Fri, 2 Jan 2015 11:43:32 +0000 (+0100) Subject: legal-info: remove FOO_MANIFEST_TARBALL and FOO_MANIFEST_SITE defaults X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5027ca582fe41d0c780e86218c8c0aedad6fb4db;p=buildroot.git legal-info: remove FOO_MANIFEST_TARBALL and FOO_MANIFEST_SITE defaults When FOO_SOURCE is non-empty, FOO_MANIFEST_TARBALL is always set. When FOO_SOURCE is empty, FOO_MANIFEST_TARBALL is not set, but also never used, due to the if below which defuses the whole legal-info processing for packages that have FOO_SOURCE explicitly set to an empty string. So get rid of the default assignment to "not saved". Do it for FOO_MANIFEST_SITE as well: it is pointless to have FOO_MANIFEST_SITE with an empty FOO_SOURCE in a package. A quick grep session in the sources confirmed this assumption is indeed true for the current code. Signed-off-by: Luca Ceresoli Cc: Thomas De Schampheleire Reviewed-by: Arnout Vandecappelle (Essensium/Mind) Signed-off-by: Peter Korsgaard --- diff --git a/package/pkg-generic.mk b/package/pkg-generic.mk index 9643a30e24..38ef581a0f 100644 --- a/package/pkg-generic.mk +++ b/package/pkg-generic.mk @@ -653,8 +653,6 @@ $(2)_MANIFEST_SITE = $$(call qstrip,$$($(2)_SITE)) endif endif endif -$(2)_MANIFEST_TARBALL ?= not saved -$(2)_MANIFEST_SITE ?= not saved # legal-info: produce legally relevant info. $(1)-legal-info: