From: Tom Tromey <tromey@redhat.com>
Date: Thu, 22 Aug 2013 18:10:25 +0000 (-0600)
Subject: fix some simple thinkos in the test suite
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5030a410ad1bd9a1d4aecf101ec1fa3519f04ed0;p=binutils-gdb.git

fix some simple thinkos in the test suite

This fixes some parallelization thinkos from a while ago.  I'm not
sure how the problems ever slipped through.  In addition to a thinko
fix in twice.exp, this also finishes fixing it up for parallelization.

2013-11-04  Tom Tromey  <tromey@redhat.com>

	* gdb.base/gcore-buffer-overflow.exp: Use
	standard_output_file, not standard_testfile.
	* gdb.base/twice.exp: Use standard_testfile, not
	standard_output_file.  Use gdb_remote_download.
---

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 35844c0192f..72d9c033e23 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,10 @@
+2013-11-04  Tom Tromey  <tromey@redhat.com>
+
+	* gdb.base/gcore-buffer-overflow.exp: Use
+	standard_output_file, not standard_testfile.
+	* gdb.base/twice.exp: Use standard_testfile, not
+	standard_output_file.  Use gdb_remote_download.
+
 2013-11-04  Tom Tromey  <tromey@redhat.com>
 
 	* lib/gdb.exp (get_compiler_info): Use log_file -info and
diff --git a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
index 8d0867e373a..47dccf9de79 100644
--- a/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
+++ b/gdb/testsuite/gdb.base/gcore-buffer-overflow.exp
@@ -51,4 +51,5 @@ if { ! [ runto_main ] } then {
     return -1
 }
 
-gdb_gcore_cmd [standard_testfile gcore-buffer-overflow.test] "save a corefile"
+gdb_gcore_cmd [standard_output_file gcore-buffer-overflow.test] \
+    "save a corefile"
diff --git a/gdb/testsuite/gdb.base/twice.exp b/gdb/testsuite/gdb.base/twice.exp
index 936ddcb1dfc..9e7e33487b5 100644
--- a/gdb/testsuite/gdb.base/twice.exp
+++ b/gdb/testsuite/gdb.base/twice.exp
@@ -14,7 +14,7 @@
 # along with this program.  If not, see <http://www.gnu.org/licenses/>.
 
 
-standard_output_file twice.c
+standard_testfile twice.c
 set options debug
 lappend options "additional_flags=-I."
 
@@ -23,7 +23,7 @@ set fileid [open $local_srcfile w]
 puts $fileid "#include \"twice.c\""
 close $fileid
 
-remote_download host ${srcdir}/${subdir}/twice.c twice.c
+gdb_remote_download host ${srcdir}/${subdir}/twice.c
 
 if  { [gdb_compile $local_srcfile "${binfile}" executable $options] != "" } {
      untested twice.exp