From: Eric Anholt <eric@anholt.net>
Date: Tue, 20 Nov 2012 22:28:48 +0000 (-0800)
Subject: i965: Add a note about a bug from the no-recompile-on-sampler-updates change.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=50a88e2f44133759ed38ef5661da61ed394e80cf;p=mesa.git

i965: Add a note about a bug from the no-recompile-on-sampler-updates change.

Reviewed-by: Kenneth Graunke <kenneth@whitecape.org>
---

diff --git a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
index 8967a6ce321..4bde6c7fb06 100644
--- a/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
+++ b/src/mesa/drivers/dri/i965/brw_fs_visitor.cpp
@@ -1295,6 +1295,10 @@ fs_visitor::visit(ir_texture *ir)
    fs_inst *inst = NULL;
 
    int sampler = _mesa_get_sampler_uniform_value(ir->sampler, prog, &fp->Base);
+   /* FINISHME: We're failing to recompile our programs when the sampler is
+    * updated.  This only matters for the texture rectangle scale parameters
+    * (pre-gen6, or gen6+ with GL_CLAMP).
+    */
    int texunit = fp->Base.SamplerUnits[sampler];
 
    /* Should be lowered by do_lower_texture_projection */