From: Dave Airlie Date: Fri, 9 Jun 2017 01:11:29 +0000 (+0100) Subject: radv: set fmask state to all 0s when no fmask. (v2) X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=51553c0beaeb91b1f2cb3292ac55573309b1d86f;p=mesa.git radv: set fmask state to all 0s when no fmask. (v2) The shader reads the descriptor to decide if it should take the fmask value, however we weren't initing it always, which meant random crap, esp with MSAA depth textures. Fixes random hangs with: dEQP-VK.glsl.builtin_var.fragdepth.* v2: check fmask_state is not NULL Fixes: f4e499ec791 "radv: add initial non-conformant radv vulkan driver" Reviewed-by: Bas Nieuwenhuizen Signed-off-by: Dave Airlie --- diff --git a/src/amd/vulkan/radv_image.c b/src/amd/vulkan/radv_image.c index 9a2f32bec76..91c7e5ff79f 100644 --- a/src/amd/vulkan/radv_image.c +++ b/src/amd/vulkan/radv_image.c @@ -499,7 +499,8 @@ si_make_texture_descriptor(struct radv_device *device, S_008F20_PITCH_GFX6(image->fmask.pitch_in_pixels - 1); fmask_state[5] |= S_008F24_LAST_ARRAY(last_layer); } - } + } else if (fmask_state) + memset(fmask_state, 0, 8 * 4); } static void