From: Simon Marchi <simon.marchi@efficios.com>
Date: Mon, 4 Jan 2021 16:43:58 +0000 (-0500)
Subject: gdb/testsuite: use clean_restart in gdb.server/ext-run.exp
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5169ae34bc8bd92a6b4403c6565a4168360e84f8;p=binutils-gdb.git

gdb/testsuite: use clean_restart in gdb.server/ext-run.exp

I think the sequence of commands here could be replaced with
clean_restart.  The test starts with GDB not started, so it should not
be started when we reach gdb_skip_xml_test.

gdb/testsuite/ChangeLog:

	* gdb.server/ext-run.exp: Use clean_restart.

Change-Id: I8c033bad6c52f3d58d6aa377b8355fc633c7aede
---

diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog
index 3200c349fa2..053e12ebe4f 100644
--- a/gdb/testsuite/ChangeLog
+++ b/gdb/testsuite/ChangeLog
@@ -1,3 +1,7 @@
+2021-01-04  Simon Marchi  <simon.marchi@efficios.com>
+
+	* gdb.server/ext-run.exp: Use clean_restart.
+
 2021-01-04  Simon Marchi  <simon.marchi@efficios.com>
 
 	* gdb.server/stop-reply-no-thread.exp: Use build_executable
diff --git a/gdb/testsuite/gdb.server/ext-run.exp b/gdb/testsuite/gdb.server/ext-run.exp
index 7d657595463..92aef141784 100644
--- a/gdb/testsuite/gdb.server/ext-run.exp
+++ b/gdb/testsuite/gdb.server/ext-run.exp
@@ -29,14 +29,10 @@ if {[build_executable $testfile.exp $testfile $srcfile debug] == -1} {
     return -1
 }
 
-# Start with a fresh gdb, gdb_skip_xml_test must be called while gdb
-# is not running.
-
-gdb_exit
+# gdb_skip_xml_test must be called while gdb is not running.
 set do_xml_test [expr ![gdb_skip_xml_test]]
-gdb_start
-gdb_load $binfile
-gdb_reinitialize_dir $srcdir/$subdir
+
+clean_restart $binfile
 
 # Make sure we're disconnected, in case we're testing with an
 # extended-remote board, therefore already connected.