From: Andreas Sandberg <andreas.sandberg@arm.com>
Date: Wed, 27 Apr 2016 14:34:58 +0000 (+0100)
Subject: arm: Remove BreakPCEvent on guest kernel panic
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=53f58b5fc149d0d395393e0068493b935a4e53f4;p=gem5.git

arm: Remove BreakPCEvent on guest kernel panic

The LinuxArmSystem class normally provides support for panicing gem5
if the simulated kernel panics. When this is turned off (default),
gem5 uses a BreakPCEvent to provide a debugger hook into the simulator
when the kernel crashes. This hook unconditionally kills gem5 with a
SIGTRAP unless gem5 is compiled in fast mode. This is undesirable
since the panic_on_panic param already provides similar functionality.

Signed-off-by: Andreas Sandberg <andreas.sandberg@arm.com>
Reviewed-by: Nikos Nikoleris <nikos.nikoleris@arm.com>
---

diff --git a/src/arch/arm/linux/system.cc b/src/arch/arm/linux/system.cc
index a78bab5bf..a8eed49f1 100644
--- a/src/arch/arm/linux/system.cc
+++ b/src/arch/arm/linux/system.cc
@@ -68,10 +68,6 @@ LinuxArmSystem::LinuxArmSystem(Params *p)
     if (p->panic_on_panic) {
         kernelPanicEvent = addKernelFuncEventOrPanic<PanicPCEvent>(
             "panic", "Kernel panic in simulated kernel");
-    } else {
-#ifndef NDEBUG
-        kernelPanicEvent = addKernelFuncEventOrPanic<BreakPCEvent>("panic");
-#endif
     }
 
     if (p->panic_on_oops) {