From: Luke Kenneth Casson Leighton <lkcl@lkcl.net>
Date: Sat, 20 Feb 2021 21:55:57 +0000 (+0000)
Subject: add crossreference to bug #603
X-Git-Tag: convert-csv-opcode-to-binary~190
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5696642162bcad72c24c58d46bbca29beffa490c;p=soc.git

add crossreference to bug #603
---

diff --git a/src/soc/decoder/power_decoder2.py b/src/soc/decoder/power_decoder2.py
index 8c34db7e..6cf06f34 100644
--- a/src/soc/decoder/power_decoder2.py
+++ b/src/soc/decoder/power_decoder2.py
@@ -917,6 +917,10 @@ class PowerDecodeSubset(Elaboratable):
         spr = Signal(10, reset_less=True)
         comb += spr.eq(decode_spr_num(self.dec.SPR)) # from XFX
 
+        # XXX BUG - don't use hardcoded magic constants.
+        # also use ".value" otherwise the test fails.  bit of a pain
+        # https://bugs.libre-soc.org/show_bug.cgi?id=603
+
         SPR_PID   = 48  # TODO read docs for POWER9
         # Microwatt doesn't implement the partition table
         # instead has PRTBL register (SPR) to point to process table