From: Alyssa Rosenzweig Date: Fri, 12 Jul 2019 23:37:45 +0000 (-0700) Subject: panfrost: Remove bizarre hack X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=594b47d91754a0298c315bfdceef0d3e6174ee9a;p=mesa.git panfrost: Remove bizarre hack I don't think this is still necessary, and if it is, we'll have to figure out how to fix it the right way. Signed-off-by: Alyssa Rosenzweig --- diff --git a/src/gallium/drivers/panfrost/pan_context.c b/src/gallium/drivers/panfrost/pan_context.c index 7171841693c..710752f6cb5 100644 --- a/src/gallium/drivers/panfrost/pan_context.c +++ b/src/gallium/drivers/panfrost/pan_context.c @@ -1847,15 +1847,6 @@ panfrost_create_vertex_elements_state( so->num_elements = num_elements; memcpy(so->pipe, elements, sizeof(*elements) * num_elements); - /* XXX: What the cornball? This is totally, 100%, unapologetically - * nonsense. And yet it somehow fixes a regression in -bshadow - * (previously, we allocated the descriptor here... a newer commit - * removed that allocation, and then memory corruption led to - * shader_meta getting overwritten in bad ways and then the whole test - * case falling apart . TODO: LOOK INTO PLEASE XXX XXX BAD XXX XXX XXX - */ - panfrost_allocate_chunk(pan_context(pctx), 0, HEAP_DESCRIPTOR); - for (int i = 0; i < num_elements; ++i) { so->hw[i].index = i;