From: Timothy Arceri <tarceri@itsqueeze.com>
Date: Tue, 9 May 2017 02:27:41 +0000 (+1000)
Subject: mesa: replace _mesa_problem() with assert() in hash table
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=59b9544fa751aa9559fe34f2e7af7b87d44440c9;p=mesa.git

mesa: replace _mesa_problem() with assert() in hash table

There should be no way the OpenGL test suites don't hit the assert()
should we do something to cause this code path to be taken.

Reviewed-by: Samuel Pitoiset <samuel.pitoiset@gmail.com>
---

diff --git a/src/mesa/main/hash.c b/src/mesa/main/hash.c
index a3772bdfb58..5b9132a3115 100644
--- a/src/mesa/main/hash.c
+++ b/src/mesa/main/hash.c
@@ -339,12 +339,10 @@ _mesa_HashRemove_unlocked(struct _mesa_HashTable *table, GLuint key)
    assert(table);
    assert(key);
 
-   /* have to check this outside of mutex lock */
-   if (table->InDeleteAll) {
-      _mesa_problem(NULL, "_mesa_HashRemove illegally called from "
-                    "_mesa_HashDeleteAll callback function");
-      return;
-   }
+   /* assert if _mesa_HashRemove illegally called from _mesa_HashDeleteAll
+    * callback function. Have to check this outside of mutex lock.
+    */
+   assert(!table->InDeleteAll);
 
    if (key == DELETED_KEY_VALUE) {
       table->deleted_key_data = NULL;