From: Emil Velikov <emil.velikov@collabora.com>
Date: Thu, 7 Sep 2017 16:03:52 +0000 (+0100)
Subject: egl: use _eglError's 'msg' as an actual message in EGL_KHR_debug
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5af26734793c76a2faab96c5c2c1dc6517ce6cab;p=mesa.git

egl: use _eglError's 'msg' as an actual message in EGL_KHR_debug

Seemingly, the original intent behind _eglError's 'msg' was aimed to
provide a function name.

At some point, people started using it the way EGL_KHR_debug's
callback() message is meant to be used. Aka providing meaningful
information to the developer/user.

Swap the funcName/msg argument order in the _eglDebugReport() call.
The 'funcName' variable is implicitly set, props to the
_eglSetFuncName() call at the start of each public entrypoint.

Signed-off-by: Emil Velikov <emil.velikov@collabora.com>
Reviewed-by: Eric Engestrom <eric.engestrom@imgtec.com>
---

diff --git a/src/egl/main/eglcurrent.c b/src/egl/main/eglcurrent.c
index 26f42761e26..df0463d70e5 100644
--- a/src/egl/main/eglcurrent.c
+++ b/src/egl/main/eglcurrent.c
@@ -287,7 +287,7 @@ _eglError(EGLint errCode, const char *msg)
          type = EGL_DEBUG_MSG_ERROR_KHR;
       }
 
-      _eglDebugReport(errCode, msg, type, NULL);
+      _eglDebugReport(errCode, NULL, type, msg);
    } else
       _eglInternalError(errCode, msg);