From: Kenneth Graunke Date: Sun, 23 Dec 2018 07:09:16 +0000 (-0800) Subject: iris: Delete bogus comment about cube array counting. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5be72d9a20bf29e6f908594e2fa3214a24cc6271;p=mesa.git iris: Delete bogus comment about cube array counting. Both 'z' and 'depth' are counted in slices, according to the Gallium docs (context.rst). In our temporary memory, we allocate `box.depth` slices, so we need to rebase the starting slice (box.z) down to 0, and back again when writing on unmap. There's nothing strange about cubes here. --- diff --git a/src/gallium/drivers/iris/iris_resource.c b/src/gallium/drivers/iris/iris_resource.c index 1117ebec15d..0751b19267c 100644 --- a/src/gallium/drivers/iris/iris_resource.c +++ b/src/gallium/drivers/iris/iris_resource.c @@ -769,11 +769,7 @@ iris_map_tiled_memcpy(struct iris_transfer *map) unsigned x1, x2, y1, y2; tile_extents(surf, &box, xfer->level, &x1, &x2, &y1, &y2); - /* When transferring cubes, box.depth is counted in cubes, but - * box.z is counted in faces. We want to transfer only the - * specified face, but for all array elements. So, use 's' - * (the zero-based slice count) rather than box.z. - */ + /* Use 's' rather than 'box.z' to rebase the first slice to 0. */ void *ptr = map->ptr + s * xfer->layer_stride; isl_memcpy_tiled_to_linear(x1, x2, y1, y2, ptr, src, xfer->stride,