From: Jason Merrill Date: Thu, 6 Dec 2012 20:21:08 +0000 (-0500) Subject: re PR c++/54744 (internal compiler error: Segmentation fault, by dependent base,... X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5cd5a78c9b13d563f8fae2ed4f619ff5705863bf;p=gcc.git re PR c++/54744 (internal compiler error: Segmentation fault, by dependent base, member typedef and ctor-initializer) PR c++/54744 * pt.c (resolve_typename_type): Check TYPENAME_IS_RESOLVING_P on scope. * init.c (expand_member_init): Check for being in a template first. * parser.c (cp_parser_mem_initializer_list): Only check class types for equivalence to the current class. From-SVN: r194267 --- diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 28f8c674d76..bcad0c24636 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,5 +1,11 @@ 2012-12-06 Jason Merrill + PR c++/54744 + * pt.c (resolve_typename_type): Check TYPENAME_IS_RESOLVING_P on scope. + * init.c (expand_member_init): Check for being in a template first. + * parser.c (cp_parser_mem_initializer_list): Only check class types + for equivalence to the current class. + PR c++/54913 * semantics.c (finish_qualified_id_expr): convert_from_reference after building a SCOPE_REF. diff --git a/gcc/cp/init.c b/gcc/cp/init.c index 76a31c1becf..2206c169bec 100644 --- a/gcc/cp/init.c +++ b/gcc/cp/init.c @@ -1370,8 +1370,8 @@ expand_member_init (tree name) tree virtual_binfo; int i; - if (same_type_p (basetype, current_class_type) - || current_template_parms) + if (current_template_parms + || same_type_p (basetype, current_class_type)) return basetype; class_binfo = TYPE_BINFO (current_class_type); diff --git a/gcc/cp/parser.c b/gcc/cp/parser.c index a010f1fb305..3566d741f14 100644 --- a/gcc/cp/parser.c +++ b/gcc/cp/parser.c @@ -11592,7 +11592,7 @@ cp_parser_mem_initializer_list (cp_parser* parser) } /* Look for a target constructor. */ if (mem_initializer != error_mark_node - && TYPE_P (TREE_PURPOSE (mem_initializer)) + && CLASS_TYPE_P (TREE_PURPOSE (mem_initializer)) && same_type_p (TREE_PURPOSE (mem_initializer), current_class_type)) { maybe_warn_cpp0x (CPP0X_DELEGATING_CTORS); diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index 8b0ead1700b..87cd33760c2 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -20079,7 +20079,16 @@ resolve_typename_type (tree type, bool only_current_p) /* If the SCOPE is itself a TYPENAME_TYPE, then we need to resolve it first before we can figure out what NAME refers to. */ if (TREE_CODE (scope) == TYPENAME_TYPE) - scope = resolve_typename_type (scope, only_current_p); + { + if (TYPENAME_IS_RESOLVING_P (scope)) + /* Given a class template A with a dependent base with nested type C, + typedef typename A::C::C C will land us here, as trying to resolve + the initial A::C leads to the local C typedef, which leads back to + A::C::C. So we break the recursion now. */ + return type; + else + scope = resolve_typename_type (scope, only_current_p); + } /* If we don't know what SCOPE refers to, then we cannot resolve the TYPENAME_TYPE. */ if (TREE_CODE (scope) == TYPENAME_TYPE) diff --git a/gcc/testsuite/g++.dg/template/meminit3.C b/gcc/testsuite/g++.dg/template/meminit3.C new file mode 100644 index 00000000000..b6824491f37 --- /dev/null +++ b/gcc/testsuite/g++.dg/template/meminit3.C @@ -0,0 +1,12 @@ +// PR c++/54744 + +template +struct base { + typedef base base_type; +}; + +template +struct derived : base { + typedef typename derived::base_type::base_type base_type; + derived() : base_type() {} +};