From: Tom Tromey <tom@tromey.com>
Date: Fri, 31 Mar 2023 15:17:13 +0000 (-0600)
Subject: Fix maybe-uninitialized warning in frame.c
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5d49758d2c04dcf0d685f99e85a553e7c3891e34;p=binutils-gdb.git

Fix maybe-uninitialized warning in frame.c

A recent patch caused my system gcc (Fedora 36, so gcc 12.2.1) to warn
about sym_addr being possibly uninitialized in frame.c.  It isn't, but
the compiler can't tell.  So, this patch initializes the variable.  I
also fixed a formatting buglet that I missed in review.
---

diff --git a/gdb/frame.c b/gdb/frame.c
index 4f420f138f6..36fb02f3c8e 100644
--- a/gdb/frame.c
+++ b/gdb/frame.c
@@ -2537,7 +2537,7 @@ inside_main_func (frame_info_ptr this_frame)
   if (current_program_space->symfile_object_file == nullptr)
     return false;
 
-  CORE_ADDR sym_addr;
+  CORE_ADDR sym_addr = 0;
   const char *name = main_name ();
   bound_minimal_symbol msymbol
     = lookup_minimal_symbol (name, NULL,
@@ -2573,8 +2573,9 @@ inside_main_func (frame_info_ptr this_frame)
 
   /* Convert any function descriptor addresses into the actual function
      code address.  */
-  sym_addr = gdbarch_convert_from_func_ptr_addr
-    (get_frame_arch (this_frame), sym_addr, current_inferior ()->top_target ());
+  sym_addr = (gdbarch_convert_from_func_ptr_addr
+	      (get_frame_arch (this_frame), sym_addr,
+	       current_inferior ()->top_target ()));
 
   return sym_addr == get_frame_func (this_frame);
 }