From: Jan Beulich <jbeulich@suse.com>
Date: Tue, 9 Mar 2021 11:40:13 +0000 (+0100)
Subject: ld: adjust PE base relocations testcase
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5dc75cf3254c1b3c5b62125f47b543407836a4b6;p=binutils-gdb.git

ld: adjust PE base relocations testcase

mcore-pe and sh-pe pointed out that the testcase added by 6fa7408d72b3
("ld: don't generate base relocations in PE output for absolute
symbols") wasn't quite generic enough yet. Copy entry point stuff from
another test and increase alignment to also cover targets with a page
size lower than 4k.

Despite all of this the test needs to be xfail-ed for mcore, as this
target isn't included in the set getting DLL_SUPPORT enabled in
emultempl/pe.em, and hence no base relocations get generated there
(yet).
---

diff --git a/ld/ChangeLog b/ld/ChangeLog
index 1b98c81a6a8..c51332ad5c6 100644
--- a/ld/ChangeLog
+++ b/ld/ChangeLog
@@ -1,3 +1,9 @@
+2021-03-09  Jan Beulich  <jbeulich@suse.com>
+
+	* testsuite/ld-pe/reloc.s: Add entry point symbols. Increase
+	alignment to 4k.
+	* testsuite/ld-pe/reloc.d: xfail for mcore.
+
 2021-03-09  Jan Beulich  <jbeulich@suse.com>
 
 	* testsuite/ld-scripts/alignof.exp,
diff --git a/ld/testsuite/ld-pe/reloc.d b/ld/testsuite/ld-pe/reloc.d
index 55888c3bdf1..eab8dfb9b02 100644
--- a/ld/testsuite/ld-pe/reloc.d
+++ b/ld/testsuite/ld-pe/reloc.d
@@ -1,6 +1,7 @@
 #name: PE base relocations
 #ld: --enable-reloc-section
 #objdump: -p
+#xfail: mcore-*-*
 
 .*:     file format .*
 
diff --git a/ld/testsuite/ld-pe/reloc.s b/ld/testsuite/ld-pe/reloc.s
index 3ed2e02e70d..d1ea0a7817f 100644
--- a/ld/testsuite/ld-pe/reloc.s
+++ b/ld/testsuite/ld-pe/reloc.s
@@ -1,5 +1,12 @@
+	.text
+	.global _start
+	.global _mainCRTStartup
+_start:
+_mainCRTStartup:
+	.byte 1
+
 	.data
-	.p2align 4
+	.p2align 12
 start:
 	.dc.a	__image_base__
 	.dc.a	start