From: Joel Brobecker <brobecker@gnat.com>
Date: Fri, 1 Jul 2011 18:36:12 +0000 (+0000)
Subject: Darwin/detach: Do not resume inferior after ptrace detach
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5e9bc145ee7e5d1e5651a996bcf81d9888b34cf1;p=binutils-gdb.git

Darwin/detach: Do not resume inferior after ptrace detach

When trying to detach from an inferior that we start from the debugger,
GDB prints the following warning:

    (gdb) detach
    Detaching from program: /[...]/foo, process 74593
    warning: Mach error at "/[...]/darwin-nat.c:445" in function "darwin_resume_inferior": (os/kern) failure (0x5)

The warning comes from the following code in darwin_detach:

     darwin_resume_inferior (inf);

This is because the process has already been resumed by the
PT_DETACH ptrace operation that has just been performed.

On the other hand, when trying to detach from an inferior that
was started outside of debugger control (thus after having attached
the debugger to that inferior), things go smoothly.  That's because
we don't use ptrace to control the process in that case, and so
the resume is perfectly justified.

This patch makes sure that we resume the inferior during the detach
only when we're NOT using ptrace.

gdb/ChangeLog:

        * darwin-nat.c (darwin_detach): Call darwin_resume_inferior
        only when inf->private->no_ptrace.
---

diff --git a/gdb/ChangeLog b/gdb/ChangeLog
index eacb247bf61..423ada3d0f5 100644
--- a/gdb/ChangeLog
+++ b/gdb/ChangeLog
@@ -1,3 +1,8 @@
+2011-07-01  Joel Brobecker  <brobecker@adacore.com>
+
+	* darwin-nat.c (darwin_detach): Call darwin_resume_inferior
+	only when inf->private->no_ptrace.
+
 2011-07-01  Joel Brobecker  <brobecker@adacore.com>
 
 	* ada-lang.c (print_it_exception): Print temporary catchpoints
diff --git a/gdb/darwin-nat.c b/gdb/darwin-nat.c
index 7be85d58701..fc5263a5c07 100644
--- a/gdb/darwin-nat.c
+++ b/gdb/darwin-nat.c
@@ -1601,7 +1601,11 @@ darwin_detach (struct target_ops *ops, char *args, int from_tty)
 
   darwin_reply_to_all_pending_messages (inf);
 
-  darwin_resume_inferior (inf);
+  /* When using ptrace, we have just performed a PT_DETACH, which
+     resumes the inferior.  On the other hand, when we are not using
+     ptrace, we need to resume its execution ourselves.  */
+  if (inf->private->no_ptrace)
+    darwin_resume_inferior (inf);
 
   darwin_mourn_inferior (ops);
 }