From: Nick Alcock Date: Tue, 2 Jun 2020 20:00:35 +0000 (+0100) Subject: libctf: having debugging enabled is unlikely X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5ec7465fec8bceb477732d6757112fe162116eb8;p=binutils-gdb.git libctf: having debugging enabled is unlikely The deduplicator can emit enormous amounts of debugging output, so much so that a later commit will introduce a new configure flag that configures most of it out (and configures it out by default). It became clear that when this configure flag is on, but debugging is not enabled via the LIBCTF_DEBUG environment variable, up to 10% of runtime can be spent on branch mispredictions checking the _libctf_debug variable. Mark it unlikely to be set (when it is set, performance is likely to be the least of your concerns). libctf/ * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set. --- diff --git a/libctf/ChangeLog b/libctf/ChangeLog index da285022dc1..48798043efd 100644 --- a/libctf/ChangeLog +++ b/libctf/ChangeLog @@ -1,3 +1,7 @@ +2020-07-22 Nick Alcock + + * ctf-subr.c (ctf_dprintf): _libctf_debug is unlikely to be set. + 2020-07-22 Nick Alcock * ctf-impl.h (struct ctf_archive_internal) diff --git a/libctf/ctf-subr.c b/libctf/ctf-subr.c index 114df843212..a5cde9d6f20 100644 --- a/libctf/ctf-subr.c +++ b/libctf/ctf-subr.c @@ -183,7 +183,7 @@ int ctf_getdebug (void) _libctf_printflike_ (1, 2) void ctf_dprintf (const char *format, ...) { - if (_libctf_debug) + if (_libctf_unlikely_ (_libctf_debug)) { va_list alist;