From: Yao Qi Date: Wed, 6 Aug 2014 05:27:57 +0000 (+0800) Subject: Fix remote/17230 X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=5ee8a82c47856b204ad76407780e454f8cfd9a72;p=binutils-gdb.git Fix remote/17230 This patch is to fix PR remote/17230, which is a leftover of the to_xfer_partial interface change. I tried splint and it reprots this problem like this, ../../../git/gdb/remote-mips.c:2236: Return value type unsigned long long does not match declared type enum target_xfer_status: len and this problem only exists in remote-mips.c. gdb: 2014-08-07 Yao Qi PR remote/17230 * remote-mips.c (mips_xfer_memory): Set *xfered_len and return TARGET_XFER_OK instead of 0. --- diff --git a/gdb/ChangeLog b/gdb/ChangeLog index 5261972379f..8146deaff61 100644 --- a/gdb/ChangeLog +++ b/gdb/ChangeLog @@ -1,3 +1,9 @@ +2014-08-07 Yao Qi + + PR remote/17230 + * remote-mips.c (mips_xfer_memory): Set *xfered_len and return + TARGET_XFER_OK instead of 0. + 2014-08-07 Gary Benson * common/common-defs.h: Include errno.h. diff --git a/gdb/remote-mips.c b/gdb/remote-mips.c index 1f1650e22e7..19ac30f978a 100644 --- a/gdb/remote-mips.c +++ b/gdb/remote-mips.c @@ -2232,7 +2232,8 @@ mips_xfer_memory (gdb_byte *readbuf, const gdb_byte *writebuf, /* Copy appropriate bytes out of the buffer. */ memcpy (readbuf, buffer + (memaddr & 3), len); } - return len; + *xfered_len = len; + return TARGET_XFER_OK; } /* Target to_xfer_partial implementation. */