From: Samuel Pitoiset Date: Mon, 18 Sep 2017 09:45:55 +0000 (+0200) Subject: radv: do not update the number of viewports in vkCmdSetViewport() X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=60878dd00ceab6528c0cdb69fbd111470a789610;p=mesa.git radv: do not update the number of viewports in vkCmdSetViewport() The Vulkan spec (1.0.61) says: "The number of viewports used by a pipeline is still specified by the viewportCount member of VkPipelineViewportStateCreateInfo." So, the number of viewports is defined at pipeline creation time and shouldn't be updated when they are set dynamically. Signed-off-by: Samuel Pitoiset Reviewed-by: Dave Airlie --- diff --git a/src/amd/vulkan/radv_cmd_buffer.c b/src/amd/vulkan/radv_cmd_buffer.c index d7b27cae27c..9724cc52940 100644 --- a/src/amd/vulkan/radv_cmd_buffer.c +++ b/src/amd/vulkan/radv_cmd_buffer.c @@ -2502,9 +2502,6 @@ void radv_CmdSetViewport( assert(firstViewport < MAX_VIEWPORTS); assert(total_count >= 1 && total_count <= MAX_VIEWPORTS); - if (cmd_buffer->state.dynamic.viewport.count < total_count) - cmd_buffer->state.dynamic.viewport.count = total_count; - memcpy(cmd_buffer->state.dynamic.viewport.viewports + firstViewport, pViewports, viewportCount * sizeof(*pViewports));