From: Carl Worth <cworth@cworth.org>
Date: Tue, 10 Aug 2010 23:52:54 +0000 (-0700)
Subject: glsl2: Initialize location structure at beginning of parse.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=60d8c46995aa9cf3f80592b9c9bb8e5be6e87502;p=mesa.git

glsl2: Initialize location structure at beginning of parse.

Since we have a custom structure for YYLTYPE locations, we need to use
an %initial-action directive to avoid triggering use of uninitialized
memory when, for example, printing error messages.

Thanks to valgrind for noticing this bug.
---

diff --git a/src/glsl/glsl_parser.ypp b/src/glsl/glsl_parser.ypp
index 493b74fb692..3e60454bb24 100644
--- a/src/glsl/glsl_parser.ypp
+++ b/src/glsl/glsl_parser.ypp
@@ -35,9 +35,17 @@
 %}
 
 %pure-parser
-%locations
 %error-verbose
 
+%locations
+%initial-action {
+   @$.first_line = 1;
+   @$.first_column = 1;
+   @$.last_line = 1;
+   @$.last_column = 1;
+   @$.source = 0;
+}
+
 %lex-param   {void *scanner}
 %parse-param {struct _mesa_glsl_parse_state *state}
 %name-prefix "_mesa_glsl_"