From: Carl Worth <cworth@cworth.org>
Date: Tue, 20 Jul 2010 01:02:12 +0000 (-0700)
Subject: glcpp: Fix use-after-free error from #undef directive.
X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=61ebc01dfecda0963a184e881ea966e2d92f0519;p=mesa.git

glcpp: Fix use-after-free error from #undef directive.

By taking advantage of the recently-added hash_table_remove function.

With this change, all existing tests are now valgrind-clean.
---

diff --git a/src/glsl/glcpp/glcpp-parse.y b/src/glsl/glcpp/glcpp-parse.y
index e5544fe29b8..a2b54eff507 100644
--- a/src/glsl/glcpp/glcpp-parse.y
+++ b/src/glsl/glcpp/glcpp-parse.y
@@ -202,10 +202,7 @@ control_line:
 |	HASH_UNDEF IDENTIFIER NEWLINE {
 		macro_t *macro = hash_table_find (parser->defines, $2);
 		if (macro) {
-			/* XXX: Need hash table to support a real way
-			 * to remove an element rather than prefixing
-			 * a new node with data of NULL like this. */
-			hash_table_insert (parser->defines, NULL, $2);
+			hash_table_remove (parser->defines, $2);
 			talloc_free (macro);
 		}
 		talloc_free ($2);