From: Jeff Law Date: Wed, 4 Dec 1996 18:02:00 +0000 (+0000) Subject: * simops.c: "add imm,sp" does not effect the condition codes. X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=61ecca95c05b272c45bf8134d52ea06a05873adf;p=binutils-gdb.git * simops.c: "add imm,sp" does not effect the condition codes. "inc dn" does effect the condition codes. Just something I noticed. --- diff --git a/sim/mn10300/ChangeLog b/sim/mn10300/ChangeLog index ce0dc915a1c..673189174a9 100644 --- a/sim/mn10300/ChangeLog +++ b/sim/mn10300/ChangeLog @@ -1,3 +1,8 @@ +Wed Dec 4 10:57:53 1996 Jeffrey A Law (law@cygnus.com) + + * simops.c: "add imm,sp" does not effect the condition codes. + "inc dn" does effect the condition codes. + Tue Dec 3 17:37:45 1996 Jeffrey A Law (law@cygnus.com) * simops.c: Treat both operands as signed values for diff --git a/sim/mn10300/simops.c b/sim/mn10300/simops.c index 6b4fde6f4cd..c3ecc4ec9ed 100644 --- a/sim/mn10300/simops.c +++ b/sim/mn10300/simops.c @@ -1148,16 +1148,6 @@ void OP_F8FE00 () imm = SEXT8 (insn & 0xff); value = reg1 + imm; State.regs[REG_SP] = value; - - z = (value == 0); - n = (value & 0x80000000); - c = (reg1 < imm); - v = ((reg1 & 0x80000000) != (imm & 0x80000000) - && (reg1 & 0x80000000) != (value & 0x80000000)); - - PSW &= ~(PSW_Z | PSW_N | PSW_C | PSW_V); - PSW |= ((z ? PSW_Z : 0) | ( n ? PSW_N : 0) - | (c ? PSW_C : 0) | (v ? PSW_V : 0)); } /* add imm16,sp */ @@ -1170,16 +1160,6 @@ void OP_FAFE0000 () imm = SEXT16 (insn & 0xffff); value = reg1 + imm; State.regs[REG_SP] = value; - - z = (value == 0); - n = (value & 0x80000000); - c = (reg1 < imm); - v = ((reg1 & 0x80000000) != (imm & 0x80000000) - && (reg1 & 0x80000000) != (value & 0x80000000)); - - PSW &= ~(PSW_Z | PSW_N | PSW_C | PSW_V); - PSW |= ((z ? PSW_Z : 0) | ( n ? PSW_N : 0) - | (c ? PSW_C : 0) | (v ? PSW_V : 0)); } /* add imm32, sp */ @@ -1192,16 +1172,6 @@ void OP_FCFE0000 () imm = ((insn & 0xffff) << 16) | extension; value = reg1 + imm; State.regs[REG_SP] = value; - - z = (value == 0); - n = (value & 0x80000000); - c = (reg1 < imm); - v = ((reg1 & 0x80000000) != (imm & 0x80000000) - && (reg1 & 0x80000000) != (value & 0x80000000)); - - PSW &= ~(PSW_Z | PSW_N | PSW_C | PSW_V); - PSW |= ((z ? PSW_Z : 0) | ( n ? PSW_N : 0) - | (c ? PSW_C : 0) | (v ? PSW_V : 0)); } /* addc dm,dn */ @@ -1453,7 +1423,21 @@ void OP_F270 () /* inc dn */ void OP_40 () { - State.regs[REG_D0 + ((insn & 0xc) >> 2)] += 1; + int z,n,c,v; + unsigned int value; + + value = State.regs[REG_D0 + ((insn & 0xc) >> 2)] + 1; + State.regs[REG_D0 + ((insn & 0xc) >> 2)] = value; + + z = (value == 0); + n = (value & 0x80000000); + c = (reg1 < reg2); + v = ((reg2 & 0x80000000) != (reg1 & 0x80000000) + && (reg2 & 0x80000000) != (value & 0x80000000)); + + PSW &= ~(PSW_Z | PSW_N | PSW_C | PSW_V); + PSW |= ((z ? PSW_Z : 0) | ( n ? PSW_N : 0) + | (c ? PSW_C : 0) | (v ? PSW_V : 0)); } /* inc an */