From: Vadim Kochan Date: Tue, 9 Apr 2019 13:55:04 +0000 (+0300) Subject: package/gettext-tiny: drop dependency of host-variant on libiconv X-Git-Url: https://git.libre-soc.org/?a=commitdiff_plain;h=63af60fae344f5784929af229caf9a4d46baa23a;p=buildroot.git package/gettext-tiny: drop dependency of host-variant on libiconv The host variant of gettext-tiny incorrectly has a dependency on the target libiconv. Not only this is wrong (a host package cannot use a target library), but it also causes a circular dependencies: host-gettext-tiny is needed as part of the toolchain build in some configurations, and all target packages depend on the toolchain being available. For host packages, we assume that iconv functionnality is provided by the host system, so there is no host-libiconv package. Signed-off-by: Vadim Kochan Reviewed-by: Alexey Brodkin [Thomas: rework commit log] Signed-off-by: Thomas Petazzoni --- diff --git a/package/gettext-tiny/gettext-tiny.mk b/package/gettext-tiny/gettext-tiny.mk index 4fa014e8dd..87e90bcc70 100644 --- a/package/gettext-tiny/gettext-tiny.mk +++ b/package/gettext-tiny/gettext-tiny.mk @@ -49,10 +49,6 @@ define HOST_GETTEXT_TINY_COPY_EXTRA_FILES endef HOST_GETTEXT_TINY_POST_PATCH_HOOKS += HOST_GETTEXT_TINY_COPY_EXTRA_FILES -ifeq ($(BR2_ENABLE_LOCALE),) -HOST_GETTEXT_TINY_DEPENDENCIES = libiconv -endif - define HOST_GETTEXT_TINY_BUILD_CMDS $(HOST_MAKE_ENV) $(MAKE) -C $(@D) \ $(HOST_CONFIGURE_OPTS) \